Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use a npm prepare script #48

Closed
pct-cclausen opened this issue Oct 18, 2023 · 2 comments · Fixed by #50
Closed

Do not use a npm prepare script #48

pct-cclausen opened this issue Oct 18, 2023 · 2 comments · Fixed by #50
Assignees
Labels
enhancement New feature or request

Comments

@pct-cclausen
Copy link

In our workspace using NX with @nxext/capacitor we have a somewhat special (?) situation where everything works great, except it turns out that if a capacitor plugins defines a prepare step in its npm scripts, @nxext/capacitor:cap sync causes that prepare step to trigger.

For this library it means the dist folder of file-opener in node_modules is deleted, breaking the lib.

See here for more details: nxext/nx-extensions-ionic#4

It turns out that for the last 15 capacitor plugins we have not had any problems, as none of them use a prepare step, and our setup works great.

file-opener however uses a prepare step. Maybe it's build process could somehow be modified in a small way to not use it?

@ryaa ryaa self-assigned this Oct 18, 2023
@ryaa ryaa added the enhancement New feature or request label Oct 18, 2023
@ryaa ryaa pinned this issue Oct 18, 2023
ryaa added a commit that referenced this issue Nov 15, 2023
@ryaa ryaa linked a pull request Nov 15, 2023 that will close this issue
@ryaa ryaa closed this as completed in #50 Nov 15, 2023
ryaa added a commit that referenced this issue Nov 15, 2023
…-npm-prepare-script

Do not use a npm prepare script #48
@ryaa
Copy link
Member

ryaa commented Nov 15, 2023

I have removed prepare script from package.json (see #50). Let me know if this fixes your issue. Thank you

@pct-cclausen
Copy link
Author

thanks, this helps :)

@ryaa ryaa unpinned this issue Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants