fix: update AVCaptureSession.Preset resolution, enable ultrawide camera #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iPhone devices after iPhone 13 have macro mode of capturing, in order for device to use it ultraWide angle must be enabled. this commit enables ultraWide(tripleCamera) if the device supports it, if not it enables dualCamera, if none of them is available then it uses wideCamera that every iPhone has. also this commit changes AVCaptureSession.Preset resolution to hd1920x1080, since it is not anymore problem for the device to analyze frames of that size. It improves oveerall scanning, scanning is much faster.
robingenz
requested changes
Jan 31, 2025
| @@ -43,15 +43,25 @@ public protocol BarcodeScannerViewDelegate { | |||
|
|
|||
| let captureSession = AVCaptureSession() | |||
| captureSession.beginConfiguration() | |||
| captureSession.sessionPreset = AVCaptureSession.Preset.hd1280x720 | |||
| captureSession.sessionPreset = AVCaptureSession.Preset.hd1920x1080 | |||
There was a problem hiding this comment.
Please revert this as this is a breaking change. Instead, you can create a separate PR to fix a bug. It should already be possible to set this setting via the resolution property. However, this does not seem to be the case at the moment.
|
@prdjed Please also take a look at the pull request checklist. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
iPhone devices after iPhone 13 have macro mode of capturing, in order for device to use it ultraWideAngle camera must be enabled. This commit enables ultraWide(tripleCamera) if the device supports it, if not it enables dualCamera, if none of them is available then it uses wideCamera that every iPhone has.
also this commit changes AVCaptureSession.Preset resolution to hd1920x1080, since it is not anymore problem for the device to analyze frames of that size. It improves oveerall scanning, scanning is much faster.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run changeset).