Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] LiveView check for invalid certificate counter #1605

Closed
sunapi386 opened this issue Feb 9, 2023 · 3 comments
Closed

[Feature request] LiveView check for invalid certificate counter #1605

sunapi386 opened this issue Feb 9, 2023 · 3 comments
Labels
enhancement New feature or request scripts Update to scripts in guild-operators

Comments

@sunapi386
Copy link

Describe
LiveView should check the certificate counter.

If the OnDisk counter differs from the OnChain counter by more than 1, the certificate will be invalid.

https://developers.cardano.org/docs/stake-pool-course/assignments/kes_period/#how-do-i-know-if-i-have-issued-an-invalid-operational-certificate

The purpose is to guard against this scenario IntersectMBO/cardano-node#4114

@Scitz0 Scitz0 added the enhancement New feature or request label Feb 9, 2023
@Scitz0
Copy link
Contributor

Scitz0 commented Feb 9, 2023

We will take the suggested change into consideration for an upcoming release.

@rdlrt
Copy link
Contributor

rdlrt commented Aug 5, 2023

Just a note - we would not want to rely on CLI or storage - but look at runtime (in line with all metrics gLV shows), we already had an item to use Koios query layer to check for latest OpCert metrics for given pool which would be refreshed at:

  • KES time interval change;
  • Startup of gLiveView;
  • PID change of node

Also, we would need to note that KOIOS_MODE being set to N (or test_koios failing) will disable this check, the test_koios should only be called once at gLiveView startup. Worth noting that CNTools users (who allow connection to koios) already had this check , as it was taken care of with node version update as well.

This is in line with Catalyst proposal from Koios to further integrate between query layer and SPO tools

@rdlrt rdlrt moved this to Next Up in Koios Project Aug 5, 2023
@rdlrt rdlrt added the scripts Update to scripts in guild-operators label Aug 5, 2023
@rdlrt
Copy link
Contributor

rdlrt commented Nov 21, 2023

Closed in #1705

@rdlrt rdlrt closed this as completed Nov 21, 2023
@github-project-automation github-project-automation bot moved this from Next Up to Testing in Koios Project Nov 21, 2023
@rdlrt rdlrt moved this from Testing to Completed in Koios Project Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request scripts Update to scripts in guild-operators
Projects
Status: Completed
Development

No branches or pull requests

3 participants