Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building container images in forked repositories fails #1751

Closed
TrevorBenson opened this issue Apr 12, 2024 · 1 comment · Fixed by #1754
Closed

Building container images in forked repositories fails #1751

TrevorBenson opened this issue Apr 12, 2024 · 1 comment · Fixed by #1754
Assignees
Labels
bug Something isn't working docker scripts Update to scripts in guild-operators

Comments

@TrevorBenson
Copy link
Collaborator

TrevorBenson commented Apr 12, 2024

Describe the bug
The CNCLI Installer uses the G_ACCOUNT variable. The error was originally found by @Fuma419 when working on #1747, and proposed changing it back to cardano-community. Initially I suggested it be left as G_ACCOUNT and cncli be forked along with guild-operators for consistency in using G_ACCOUNT. However the forked cncli repository does not have any releases from the upstream repo which still leads to failures when installing CNCLI.

#18 6.268   Downloading CNCLI...
#18 6.452 jq: error (at <stdin>:4): Cannot iterate over null (null)
#18 6.460 curl: no URL specified!
#18 6.460 curl: try 'curl --help' or 'curl --manual' for more information
#18 6.461 ERROR: Download of latest release of CNCLI from GitHub failed! Please retry or install it manually.

Checking the forked repository latest release results in:

{
  "message": "Not Found",
  "documentation_url": "https://docs.github.com/rest/releases/releases#get-the-latest-release"
}

To Reproduce
Steps to reproduce the behavior:

  1. Fork guild-operators and cncli
  2. Go into actions
  3. Build the container for testing
  4. Observe jq and curl errors above.

Expected behavior
Building in a fork should be possible and lead to a working container image.

Additional context
Should be reproducable from any fork while guild-deploy.sh uses G_ACCOUNT for CNCLI installation steps.

@TrevorBenson TrevorBenson self-assigned this Apr 12, 2024
@TrevorBenson TrevorBenson added bug Something isn't working docker scripts Update to scripts in guild-operators labels Apr 12, 2024
@TrevorBenson
Copy link
Collaborator Author

Link to PR was missing prior to merge, but fixed in #1754 so closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working docker scripts Update to scripts in guild-operators
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant