Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New endpoint : tx_fee_estimate #191

Closed
rdlrt opened this issue May 12, 2023 · 5 comments · Fixed by #238
Closed

New endpoint : tx_fee_estimate #191

rdlrt opened this issue May 12, 2023 · 5 comments · Fixed by #238
Milestone

Comments

@rdlrt
Copy link
Contributor

rdlrt commented May 12, 2023

Provide fee estimate for uploaded tx body

@AstroWa3l
Copy link

I agree with this request, this is the endpoint missing I am looking to integrate koios with pycardano similar to blockfrost API.

https://pycardano.readthedocs.io/en/latest/api/pycardano.backend.base.html#pycardano.backend.blockfrost.BlockFrostChainContext

@QuixoteSystems
Copy link
Contributor

Yes, We need that asap to interact with Pycardano library and SC.

@rdlrt
Copy link
Contributor Author

rdlrt commented May 24, 2023

The wait is for ogmios v6 which might be next week (to avoid writing yet-another-code or to use web sockets instead of HTTP).
If there is more background about the 'asap' , happy to hear details offline

@AstroWa3l
Copy link

We can wait for Ogmios v6, as far as I know, no major project is trying to implement pycardano+koios yet but more are trying to use it every day in their development. And I agree it's best to wait to avoid writing an update that will need to be updated again.

@rdlrt rdlrt moved this to Next Up in Koios Project Aug 2, 2023
@rdlrt rdlrt added this to the Koios vNext milestone Aug 2, 2023
@rdlrt rdlrt mentioned this issue Aug 29, 2023
@rdlrt rdlrt mentioned this issue Oct 6, 2023
59 tasks
@rdlrt
Copy link
Contributor Author

rdlrt commented Oct 6, 2023

Closed via #238

@rdlrt rdlrt closed this as completed Oct 6, 2023
@github-project-automation github-project-automation bot moved this from Next Up to Testing in Koios Project Oct 6, 2023
rdlrt added a commit that referenced this issue Oct 13, 2023
## Description
<!--- Describe your changes -->
[Re-created from #227 post renaming base-branch]

- [x] pool_list: Return all fields from pool_info_cache (latest pool entry)
- [x] Remove filter for returning only 'registered' pools from pool_list, pool_relays and pool_metadata endpoints
- [x] Few more linting polishing (remove trailing spaces, move single column/table references onto same line)
- [x] Update pool_info to return same metadata as pool_list and pool_metadata (latest w/o fallback)
- [x] Update all tx_in joins to use the new tx_out.consumed_by_tx_in_id
- [x] Dont include epoch_params in epoch_info_cache, update references accordingly
- [x] Update `*_txs` as per #186 (point 4)
- [x] Update `*_utxos` as per #186 (point 3)
  - [x] credential_utxos
  - [x] address_utxos
  - [x] account_utxos
  - [x] utxo_info
  - [x] asset_utxos
  - [x] script_utxos
- [x] Add script_info and align all endpoints for scripts
- [x] Add temporary cron for fixing epoch count mismatch
- [x] Add pool_registrations/pool_deregistrations endpoint
- [x] Add retired txs to `pool_updates` (other fields for such transactions will return `null`)
- [x] Add reward_withdrawals/treasury_withdrawals endpoint
- [x] Simplify address_assets and account_assets heirarchy to return flat table (helps do horizontal filtering as desired)
- [x] API Spec updates:
  - [x] Add section for Authentication
  - [x] Bump Koios version
  - [x] pool_list
  - [x] pool_metadata
  - [x] pool_relay
  - [x] `*_txs`
  - [x] `*_utxos`
  - [x] `address_assets`
  - [x] `account_assets`
  - [x] `epoch_params`
  - [x] `pool_registrations`/`pool_deregistrations`
  - [x] `reward_withdrawals`/`treasury_withdrawals`
  - [x] All script-related endpoints
  - [x] Update examples
  - [x] Check re-usability
  - [x] Check schemathesis
    - [x] guild
    - [x] preview
    - [x] preprod
    - [x] mainnet
- [x] Add v0 vs v1 to monitoring
  - [x] guild
  - [ ] preview (post merge)
  - [ ] preprod (post merge)
  - [ ] mainnet (post 1.1.0 - instead of 1.1.0rc) release

- [x] Ogmios
  - [x] Add integration for tx Evaluation and submission using ogmios path
  - [x] Add health check based on /health (`version` and `networkSynchronization`)
- [x] Update CHANGELOG
- [x] Bump final specs version number to v1 

## Which issue it fixes?
<!--- Link to issue: Closes #issue-number -->
- [x] Closes #208
- [x] Closes #218
- [x] Closes #186 
- [x] Closes #221
- [x] Closes #224
- [x] Closes #191
- [x] Closes #232
- [x] Closes #240 #241

---------

Co-authored-by: KoT_B_KocMoce <[email protected]>
Co-authored-by: Ola [AHLNET] <[email protected]>
@rdlrt rdlrt moved this from Testing to Completed in Koios Project Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

3 participants