-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CIP-0119 - Inconsistent field name #945
Comments
Thanks @palas - I can see the consistency. I don't work with related tooling so I'm tagging some reviewers & stakeholders to choose which term is canonical & agree upon a plan to change the other one. If there's no obvious choice about which is canonical, or uncertain implications in changing it, we'll put it up for discussion on Discord and/or the next CIP meeting. cc @Thomas-Upfield @Ryun1 @gitmachtl @perturbing @Crypto2099 @Quantumplation |
@palas i agree. |
@palas please confirm here if you'd like to submit a pull request standardising on |
Sorry, I just saw the message. I am happy to make a PR to address this and also #949 |
yes (and I also made #949 (comment) before seeing this), we appreciate the help @palas & I'll review and pass them along ASAP as soon as you submit the pull requests. |
I've noticed when addressing this issue that while the schema calls this field
"type"
, in this example it is written as"@type"
. We probably should make this consistent. And I imagine we should favour"@type"
for consistency with CIP-0100The text was updated successfully, but these errors were encountered: