MultipleChoiceFilter not working? #1603
-
|
I have the following model: and the following filter: however - "...?group_classification=A&group_classification=B" in my querystring generates no SQL criteria in the WHERE clause for the "group_classification" field. but if I change "group_classification = django_filters.MultipleChoiceFilter" to "group_classification = django_filters.ChoiceFilter", the SQL query will generate "WHERE group_classification IN (B)" Can anyone tell me what I'm doing wrong? |
Beta Was this translation helpful? Give feedback.
Replies: 5 comments 6 replies
-
|
Hi @sheckathorne — Not sure. I added a test in #1604 showing For FilterSet instance |
Beta Was this translation helpful? Give feedback.
-
|
Thank you for the quick reply! I found the issue and I'm not exactly sure the best way to handle it: For context, the choices for group_classifcation are: What I found is that in django_filters.filterset.py: The values from my querystring aren't coming through in the cleaned data because they are failing form validation. If selecting "A" and "B" from my choices, the value being validated in my form is "[A,B]" and not "A" and "B" separately. My model field group_classification is expecting a single value "A" or "B" and "[A,B]" is not an acceptable choice. The simple fix for my case was to prevent validation on that field since the form action is GET and not POST, but not sure if there's a better way. Hopefully this can help someone else in the future. |
Beta Was this translation helpful? Give feedback.
-
|
Validation should be on each item in the list, not the whole list at one shot... 🤔 |
Beta Was this translation helpful? Give feedback.
-
|
If you're interested: print(f.form.errors): |
Beta Was this translation helpful? Give feedback.
-
|
Hi @sheckathorne. There's something else going on in your case that I can't see from here. Adding this diff to the test suite passes as expected: diff --git a/tests/test_filtering.py b/tests/test_filtering.py
index b9b30f9..1a33602 100644
--- a/tests/test_filtering.py
+++ b/tests/test_filtering.py
@@ -1488,6 +1488,15 @@ class M2MRelationshipTests(TestCase):
f.qs, ['aaron', 'alex'],
lambda o: o.username,
)
+ f = F(
+ QueryDict('favorite_books__title=Ender%27s+Game&favorite_books__title=Snowcrash'),
+ queryset=qs
+ )
+ self.assertIs(True, f.form.is_valid(), list(f.filters["favorite_books__title"].field.choices))
+ self.assertQuerySetEqual(
+ f.qs, ['aaron', 'alex'],
+ lambda o: o.username,
+ )
class F(FilterSet):
favorite_books__title = AllValuesFilter()What's the widget being used? 🤔 The equivalents from the test case here are:
It looks like for the second you're getting: |
Beta Was this translation helpful? Give feedback.
-
|
Here's the output from each of the following: print(f.form.fields["group_classification"].widget) print(f.form.fields["group_classification"].widget.value_from_datadict(request.GET, {}, "group_classification")) print(type(f.form.fields["group_classification"].widget.value_from_datadict(request.GET, {}, "group_classification"))) print(f.form.errors): Help text screenshot: I totally agree that it appears as though the validation is attempting to validate a stringified list, but my output says different. I think we both agree that this is not a django-filter problem, so we can continue this conversation at your discretion. Thanks for all your help in tracking down some of the issues I'm having. |
Beta Was this translation helpful? Give feedback.
-
|
What I think is happening, is that my model field is a CharField: ...so the to_python() method for that field is coercing the data from f.form.fields["group_classification"].widget.value_from_datadict(request.GET, {}, "group_classification") to a String, and the validatle() method raises an error because the string "['A','B','C']" is obviously not a valid choice. I'm not a Django expert, do you recommend I override the to_python() and validate() methods for my field? Or should this be working out of the box? |
Beta Was this translation helpful? Give feedback.
-
|
For anyone else reading this, my solution was to extend the models.CharField class and overwrite the clean() and to_python() methods to allow for either string or list: |
Beta Was this translation helpful? Give feedback.
-
|
Hi @sheckathorne — are you able to capture the traceback to the Something like this in your subclass should do it… |
Beta Was this translation helpful? Give feedback.
-
File "/opt/homebrew/Cellar/[email protected]/3.10.10_1/Frameworks/Python.framework/Versions/3.10/lib/python3.10/threading.py", line 973, in _bootstrap |
Beta Was this translation helpful? Give feedback.
-
|
Thanks for that @sheckathorne. I'll ponder this. 🤔 |
Beta Was this translation helpful? Give feedback.
Hi @sheckathorne — Not sure. I added a test in #1604 showing
MultipleChoiceFilterworking as expected.For FilterSet instance
f, I suggest looking atf.form.is_valid(),f.form.errors,list(f.form["group_classification"].choices), andf.qs.query. Hopefully something there will show up as not as you're expecting.