Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document use of dark mode images for images with meaningful color #220

Open
ErinBecker opened this issue Jan 23, 2025 · 0 comments
Open

Comments

@ErinBecker
Copy link
Contributor

Automatic conversion of images to dark mode was added to {varnish} in carpentries/varnish#153. There are specific instances in which it doesn't make sense to display a dark mode version of the image, as for example when the image is a screencapture of a tool output where the color scheme is meaningful. This is demonstrated in the images below, which show a FastQC screenshot in the Data Carpentry Genomics curriculum (above) and the corresponding dark-i-fied image (below).

Image Image

After discussion with @tobyhodges and @froggleston, we think the right approach to take for situations like this is to prompt Maintainers to explicitly set the light mode version of the image as the dark mode image. Leaving this note here to make sure we add this to documentation and communicate with Maintainers before the next {varnish} release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant