Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty Node Config being inserted on the database #518

Open
2 tasks
GMKrieger opened this issue Jul 12, 2024 · 0 comments
Open
2 tasks

Empty Node Config being inserted on the database #518

GMKrieger opened this issue Jul 12, 2024 · 0 comments
Labels
bug Something isn't working #feat:db Feature: database
Milestone

Comments

@GMKrieger
Copy link
Contributor

📚 Context

The node_config table on the database requires all its values to be not null, and should return an error if trying to insert null values.

When creating a NodePersistentConfig object to insert in the database, an incomplete struct with missing values is still inserted in the database, meaning the values aren't defaulting to nil and it's inserting something we don't know.

✔️ Solution

We need to investigate what are the default values when creating the model, and change them to be nil. It shouldn't work unless we provide every information.

📈 Subtasks

  • Investigate model default values
  • Update model creation to require all values
@GMKrieger GMKrieger added the bug Something isn't working label Jul 12, 2024
@GMKrieger GMKrieger moved this to 📋 Backlog in Node Unit Jul 12, 2024
@marcelstanley marcelstanley added this to the TBD milestone Jul 26, 2024
@marcelstanley marcelstanley modified the milestones: TBD, 2.0.0 Aug 2, 2024
@marcelstanley marcelstanley added the #feat:db Feature: database label Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working #feat:db Feature: database
Projects
Status: 📋 Backlog
Development

No branches or pull requests

2 participants