-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added regex and cleanup string algo for repo based tag generator #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcmadhankumar
had a problem deploying
to
TanzuNet Registry Dev e2e
October 9, 2023 18:18 — with
GitHub Actions
Failure
rcmadhankumar
temporarily deployed
to
TanzuNet Registry Dev e2e
October 10, 2023 05:43 — with
GitHub Actions
Inactive
rcmadhankumar
force-pushed
the
issue-582
branch
from
October 11, 2023 04:08
fcf6aa8
to
dc0b82c
Compare
rcmadhankumar
temporarily deployed
to
TanzuNet Registry Dev e2e
October 11, 2023 04:09 — with
GitHub Actions
Inactive
rcmadhankumar
had a problem deploying
to
GCR e2e
October 11, 2023 04:09 — with
GitHub Actions
Failure
rcmadhankumar
temporarily deployed
to
TanzuNet Registry Dev e2e
October 12, 2023 09:13 — with
GitHub Actions
Inactive
rcmadhankumar
force-pushed
the
issue-582
branch
from
October 13, 2023 09:05
dc0b82c
to
d7bea24
Compare
rcmadhankumar
temporarily deployed
to
TanzuNet Registry Dev e2e
October 13, 2023 09:05 — with
GitHub Actions
Inactive
rcmadhankumar
force-pushed
the
issue-582
branch
from
October 16, 2023 08:29
d7bea24
to
893073b
Compare
rcmadhankumar
temporarily deployed
to
TanzuNet Registry Dev e2e
October 16, 2023 08:29 — with
GitHub Actions
Inactive
rcmadhankumar
temporarily deployed
to
TanzuNet Registry Dev e2e
October 16, 2023 10:29 — with
GitHub Actions
Inactive
Signed-off-by: rcmadhankumar <[email protected]>
rcmadhankumar
force-pushed
the
issue-582
branch
from
October 16, 2023 10:34
893073b
to
4ba73cf
Compare
rcmadhankumar
temporarily deployed
to
TanzuNet Registry Dev e2e
October 16, 2023 10:34 — with
GitHub Actions
Inactive
joaopapereira
approved these changes
Oct 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/cherry-pick v0.37.x |
github-actions
bot
added
the
carvel triage
This issue has not yet been reviewed for validity
label
Nov 6, 2023
/cherry-pick v0.36.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added regex to verify for generating the repo based tags.
Added new unit tests to verify various repo path inputs.
Fixes: #582
Verification:
Created a Package repository that has a package referencing an imgpkg bundle named
.dev-pkg-apiextensions-storageversion-cmd-migrate
in the artifactory. Copied the package repository with imgpkg copy command along with--repo-based-tags
flag. imgpkg bundle was shifted with the tagdev-pkg-apiextensions-storageversion-cmd-migrate
and the.
in the beginning was removed as expected.