Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kctrl: values with an empty object default in Helm get the string "{}" as a default in OpenAPI #1448

Closed
gcapizzi opened this issue Jan 18, 2024 · 0 comments · Fixed by #1449
Labels
bug This issue describes a defect or unexpected behavior

Comments

@gcapizzi
Copy link
Contributor

What steps did you take:

kctrl package release --openapi-schema of a package using a helmTemplate.

What happened:

Helm values with an empty object as a default, e.g.

# -- Add `affinities` to the Crossplane pod deployment.
affinity: {}

get a string default in OpenAPI:

{
  "default": "{}",
  "description": "Add `affinities` to the Crossplane pod deployment.",
  "type": "object"
}

What did you expect:

An empty object default:

{
  "default": {},
  "description": "Add `affinities` to the Crossplane pod deployment.",
  "type": "object"
}

Vote on this request

This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.

👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"

We are also happy to receive and review Pull Requests if you want to help working on this issue.

@gcapizzi gcapizzi added bug This issue describes a defect or unexpected behavior carvel-triage This issue has not yet been reviewed for validity labels Jan 18, 2024
@gcapizzi gcapizzi changed the title kctrl: values with an empty object default value in Helm get the string "{}" as a default in OpenAPI kctrl: values with an empty object default in Helm get the string "{}" as a default in OpenAPI Jan 18, 2024
@github-project-automation github-project-automation bot moved this to Closed in Carvel Jan 24, 2024
@github-actions github-actions bot removed the carvel-triage This issue has not yet been reviewed for validity label Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue describes a defect or unexpected behavior
Projects
Archived in project
1 participant