Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include FailedCreate condition in deployment waiting logic #350

Closed
cppforlife opened this issue Oct 8, 2021 · 2 comments · Fixed by #878
Closed

include FailedCreate condition in deployment waiting logic #350

cppforlife opened this issue Oct 8, 2021 · 2 comments · Fixed by #878
Labels
carvel accepted This issue should be considered for future work and that the triage process has been completed enhancement This issue is a feature request good first issue An issue that will be a good candidate for a new contributor

Comments

@cppforlife
Copy link
Contributor

Describe the problem/challenge you have
currently Deployment waiting code looks at several conditions include FailedDelete [0]. there is another condition that would be useful to look at it FailedCreate. we should add that check in there so that we can show nice informational message to the users as part of the progress log. i do not think we need to consider progress as done though, in this case.

[0] https://github.com/vmware-tanzu/carvel-kapp/blob/develop/pkg/kapp/resourcesmisc/apps_v1_deployment.go#L57-L62


Vote on this request

This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.

👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"

We are also happy to receive and review Pull Requests if you want to help working on this issue.

@cppforlife cppforlife added enhancement This issue is a feature request good first issue An issue that will be a good candidate for a new contributor carvel accepted This issue should be considered for future work and that the triage process has been completed Hacktoberfest labels Oct 8, 2021
@cppforlife cppforlife changed the title include FailedCreate condition include FailedCreate condition in deployment waiting logic Oct 8, 2021
@aaronshurley aaronshurley moved this to To Triage in Carvel Jul 27, 2022
@rohitagg2020
Copy link
Contributor

Not picking it up as it is marked as good first issue. Do reach out in case more context is needed.

@renuy renuy moved this from To Triage to Unprioritized in Carvel Aug 29, 2022
@github-project-automation github-project-automation bot moved this to To Triage in Carvel Feb 14, 2023
@jignyasamishra
Copy link
Contributor

Hello @cppforlife I have raised a PR, please have a look at it. Thank you!!!

@github-project-automation github-project-automation bot moved this from To Triage to Closed in Carvel Jan 13, 2024
@github-project-automation github-project-automation bot moved this from Unprioritized to Closed in Carvel Jan 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
carvel accepted This issue should be considered for future work and that the triage process has been completed enhancement This issue is a feature request good first issue An issue that will be a good candidate for a new contributor
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants