Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support path key prefix selection in Config #62

Closed
1 of 5 tasks
cwlbraa opened this issue Dec 18, 2019 · 3 comments
Closed
1 of 5 tasks

support path key prefix selection in Config #62

cwlbraa opened this issue Dec 18, 2019 · 3 comments
Assignees
Labels
carvel accepted This issue should be considered for future work and that the triage process has been completed enhancement This issue is a feature request priority/important-soon Must be staffed and worked on currently or soon.

Comments

@cwlbraa
Copy link

cwlbraa commented Dec 18, 2019

I'd like to write a rebase rule that always pulls all of the cert-manager.io/ annotations for secrets out of the cluster, but right now I think I have to write that like this:

rebaseRules:
- path: [metadata, annotations, "cert-manager.io/alt-names"]
  type: copy
  sources: [new, existing]
  resourceMatchers: &opaqueSecrets
  - apiVersionKindMatcher: {apiVersion: v1, kind: Secret, type: Opaque}

- path: [metadata, annotations, "cert-manager.io/certificate-name"]
  type: copy
  sources: [new, existing]
  resourceMatchers: *opaqueSecrets

- path: [metadata, annotations, "cert-manager.io/common-name"]
  type: copy
  sources: [new, existing]
  resourceMatchers: *opaqueSecrets

- path: [metadata, annotations, "cert-manager.io/ip-sans"]
  type: copy
  sources: [new, existing]
  resourceMatchers: *opaqueSecrets

- path: [metadata, annotations, "cert-manager.io/issuer-kind"]
  type: copy
  sources: [new, existing]
  resourceMatchers: *opaqueSecrets

- path: [metadata, annotations, "cert-manager.io/issuer-name"]
  type: copy
  sources: [new, existing]
  resourceMatchers: *opaqueSecrets

- path: [metadata, annotations, "cert-manager.io/uri-sans"]
  type: copy
  sources: [new, existing]
  resourceMatchers: *opaqueSecrets

when really what I want is something like:

rebaseRules:
- path: [metadata, annotations, {prefixed: "cert-manager.io/"}]
  type: copy
  sources: [new, existing]
  - apiVersionKindMatcher: {apiVersion: v1, kind: Secret, type: Opaque}

Tasks

  • rebase rules to support regex as new field in config path
  • diff stage to support new field. changes in (mod_field_copy, remove, overlay_contract mod - resources package)
  • test ownership rules, label scoping rule
  • e2e test case
  • documentation
@cppforlife cppforlife added the enhancement This issue is a feature request label Dec 19, 2019
@cppforlife cppforlife added the good first issue An issue that will be a good candidate for a new contributor label Feb 12, 2020
@iamhsk iamhsk removed the good first issue An issue that will be a good candidate for a new contributor label Sep 28, 2021
@renuy renuy added the carvel accepted This issue should be considered for future work and that the triage process has been completed label Jun 20, 2022
@renuy renuy added this to Carvel Jul 22, 2022
@renuy renuy moved this to To Triage in Carvel Jul 22, 2022
@renuy renuy moved this from To Triage to Prioritized Backlog in Carvel Aug 29, 2022
@renuy renuy assigned sethiyash and unassigned praveenrewar Sep 5, 2022
@renuy renuy added the priority/important-soon Must be staffed and worked on currently or soon. label Sep 5, 2022
@renuy renuy self-assigned this Sep 26, 2022
@sethiyash
Copy link
Contributor

sethiyash commented Sep 27, 2022

Here is the Proposal on the different approaches which is still in the discussion phase.

@sethiyash
Copy link
Contributor

sethiyash commented Oct 10, 2022

Internally we decide to start supporting regex in path similar to the allIndexes we had earlier.

- path: [metadata, annotations, {regex: "^cert-manager[.]io"}]

The regex key will take the regular expression supported by Golang as a value. Please let us know your thoughts.
cc: @cwlbraa

@renuy renuy moved this from Prioritized Backlog to In Progress in Carvel Nov 2, 2022
@github-project-automation github-project-automation bot moved this to To Triage in Carvel Feb 14, 2023
@renuy renuy moved this from In Progress to Needs Review in Carvel Jun 23, 2023
@renuy renuy moved this from To Triage to In Progress in Carvel Oct 9, 2023
@renuy
Copy link
Contributor

renuy commented Oct 9, 2023

Available as part of 0.59.0.
Please confirm once, closing this issue

@renuy renuy closed this as completed Oct 9, 2023
@github-project-automation github-project-automation bot moved this from Needs Review to Closed in Carvel Oct 9, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Closed in Carvel Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
carvel accepted This issue should be considered for future work and that the triage process has been completed enhancement This issue is a feature request priority/important-soon Must be staffed and worked on currently or soon.
Projects
Archived in project
Development

No branches or pull requests

7 participants