-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kapp app-group deploy should order based on folder names #850
kapp app-group deploy should order based on folder names #850
Conversation
@rjtch DCO check is still failing, could you squash your commits and then sign the final commit? |
I don't find any solution I tried to fix it using git commit -s --amend and git commit -s -m but it did not work!!! |
@rjtch Could you make sure that the user name and the email in the signed off message are the ones that are linked to your account? |
Signed-off-by: rjtch <[email protected]>
…apps Signed-off-by: rjtch <[email protected]>
Signed-off-by: rjtch <[email protected]>
Signed-off-by: rjtch <[email protected]>
Signed-off-by: rjtch <[email protected]>
Signed-off-by: rjtch <[email protected]>
Signed-off-by: rjtch <[email protected]>
Signed-off-by: rjtch <[email protected]>
Signed-off-by: rjtch <[email protected]>
161a3ca
to
6d30856
Compare
@rjtch The DCO bot is happy now. I do see 9 commits but I don't seen any files getting changed 🤔 |
Maybe through to much rebase things got lost. I will fix it. |
Signed-off-by: rjtch <[email protected]>
Signed-off-by: rjtch <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you so much for the contribution @rjtch
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #755
Does this PR introduce a user-facing change?
Additional Notes for your reviewer:
Review Checklist:
a link to that PR
change
Additional documentation e.g., Proposal, usage docs, etc.: