Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kapp app-group deploy should order based on folder names #850

Conversation

rjtch
Copy link
Contributor

@rjtch rjtch commented Oct 20, 2023

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #755

Does this PR introduce a user-facing change?


Additional Notes for your reviewer:

Review Checklist:
  • Follows the developer guidelines
  • Relevant tests are added or updated
  • Relevant docs in this repo added or updated
  • Relevant carvel.dev docs added or updated in a separate PR and there's
    a link to that PR
  • Code is at least as readable and maintainable as it was before this
    change

Additional documentation e.g., Proposal, usage docs, etc.:


@praveenrewar
Copy link
Member

@rjtch DCO check is still failing, could you squash your commits and then sign the final commit?

@rjtch
Copy link
Contributor Author

rjtch commented Oct 27, 2023

@rjtch DCO check is still failing, could you squash your commits and then sign the final commit?

I don't find any solution I tried to fix it using git commit -s --amend and git commit -s -m but it did not work!!!

@praveenrewar
Copy link
Member

@rjtch Could you make sure that the user name and the email in the signed off message are the ones that are linked to your account?

@rjtch rjtch force-pushed the eat/755-should-order-based-on-folder-names branch from 161a3ca to 6d30856 Compare October 31, 2023 09:04
@praveenrewar
Copy link
Member

@rjtch The DCO bot is happy now. I do see 9 commits but I don't seen any files getting changed 🤔

@rjtch
Copy link
Contributor Author

rjtch commented Nov 1, 2023

@rjtch The DCO bot is happy now. I do see 9 commits but I don't seen any files getting changed 🤔

Maybe through to much rebase things got lost. I will fix it.

Copy link
Member

@praveenrewar praveenrewar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you so much for the contribution @rjtch

@praveenrewar praveenrewar changed the title Eat/755 should order based on folder names kapp app-group deploy should order based on folder names Nov 4, 2023
@praveenrewar praveenrewar merged commit 39761d2 into carvel-dev:develop Nov 4, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

kapp app-group deploy should order based on folder names
2 participants