From eea3965c9f47743a56671d49348255e5fd4d57f8 Mon Sep 17 00:00:00 2001 From: kumari tanushree Date: Fri, 5 Jan 2024 12:53:09 +0530 Subject: [PATCH] PrivateKey with or without extra char as newline will be accepted by vendir Signed-off-by: kumari tanushree --- pkg/vendir/fetch/git/git.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/pkg/vendir/fetch/git/git.go b/pkg/vendir/fetch/git/git.go index 24bfd1e8..1895a1b4 100644 --- a/pkg/vendir/fetch/git/git.go +++ b/pkg/vendir/fetch/git/git.go @@ -93,7 +93,8 @@ func (t *Git) fetch(dstPath string, tempArea ctlfetch.TempArea) error { if authOpts.PrivateKey != nil { path := filepath.Join(authDir, "private-key") - err = os.WriteFile(path, []byte(*authOpts.PrivateKey), 0600) + // Ensure the private key ends with a newline character, as git requires it to work. (https://github.com/carvel-dev/vendir/issues/350) + err = os.WriteFile(path, []byte(*authOpts.PrivateKey+"\n"), 0600) if err != nil { return fmt.Errorf("Writing private key: %s", err) }