Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blang/semver ParseRange fails to handle prereleases containing x #123

Closed
danielhelfand opened this issue Nov 30, 2021 · 0 comments · Fixed by #373
Closed

blang/semver ParseRange fails to handle prereleases containing x #123

danielhelfand opened this issue Nov 30, 2021 · 0 comments · Fixed by #373
Labels
bug This issue describes a defect or unexpected behavior carvel-accepted This issue should be considered for future work and that the triage process has been completed priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@danielhelfand
Copy link
Contributor

What steps did you take:

Run vendir tools sort-semver -v '1.1.0 1.1.1' --constraint '1.1.0-fox'

What happened:

vendir: Error: Parsing version constraint '1.1.0-fox':
  Could not get version from string: "<"

What did you expect:

The version 1.1.0-fox should be a valid semver version and not result in the error above.

Anything else you would like to add:

This error can be traced back to the blang/semver library used by vendir: https://github.com/vmware-tanzu/carvel-vendir/blob/7a076ecfdfcfc6c2cac23e1b439829da1727369f/pkg/vendir/versions/semvers.go#L76

An issue/pr to the library has been made to blang/semver. If the response to the pr moves slow, we can add the fix to the k14s/semver fork.

Environment:

  • vendir version (execute vendir --version): v0.23.0
  • OS (e.g. from /etc/os-release): N/A

Vote on this request

This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.

👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"

We are also happy to receive and review Pull Requests if you want to help working on this issue.

@danielhelfand danielhelfand added bug This issue describes a defect or unexpected behavior carvel-triage This issue has not yet been reviewed for validity carvel-accepted This issue should be considered for future work and that the triage process has been completed and removed bug This issue describes a defect or unexpected behavior carvel-triage This issue has not yet been reviewed for validity labels Nov 30, 2021
@aaronshurley aaronshurley moved this to To Triage in Carvel Jul 26, 2022
@github-project-automation github-project-automation bot moved this to To Triage in Carvel Feb 14, 2023
@neil-hickey neil-hickey moved this from To Triage to Unprioritized in Carvel Feb 22, 2023
@neil-hickey neil-hickey added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Feb 22, 2023
@github-project-automation github-project-automation bot moved this from To Triage to Closed in Carvel Apr 8, 2024
@github-project-automation github-project-automation bot moved this from Unprioritized to Closed in Carvel Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue describes a defect or unexpected behavior carvel-accepted This issue should be considered for future work and that the triage process has been completed priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants