Add snapshot tests for iOS 17

cashapp · Jan 26, 2024 · b5741bb · b5741bb
1 parent ada8279
commit b5741bb
Show file tree

Hide file tree

Showing 99 changed files with 7 additions and 1 deletion.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -12,7 +12,7 @@ jobs:
     runs-on: macOS-13
     strategy:
       matrix:
-        platform: ['iOS_16']
+        platform: ['iOS_17', 'iOS_16']
       fail-fast: false
     steps:
       - name: Checkout Repo

diff --git a/Example/SnapshotTests/ImpreciseObjectiveCTests.m b/Example/SnapshotTests/ImpreciseObjectiveCTests.m
@@ -31,6 +31,7 @@ - (void)setUp;
     [super setUp];
 
     self.fileNameOptions = FBSnapshotTestCaseFileNameIncludeOptionOS | FBSnapshotTestCaseFileNameIncludeOptionScreenSize | FBSnapshotTestCaseFileNameIncludeOptionScreenScale;
+    self.recordMode = NO;
 }
 
 - (void)testSimpleView;

diff --git a/Example/SnapshotTests/ObjectiveCTests.m b/Example/SnapshotTests/ObjectiveCTests.m
@@ -31,6 +31,7 @@ - (void)setUp;
     [super setUp];
 
     self.fileNameOptions = FBSnapshotTestCaseFileNameIncludeOptionOS | FBSnapshotTestCaseFileNameIncludeOptionScreenSize | FBSnapshotTestCaseFileNameIncludeOptionScreenScale;
+    self.recordMode = NO;
 }
 
 - (void)testSimpleView;

diff --git a/...ciseObjectiveCTests/[email protected] b/...ciseObjectiveCTests/[email protected]
diff --git a/...ciseObjectiveCTests/[email protected] b/...ciseObjectiveCTests/[email protected]
diff --git a/...ReferenceImages/_64/ImpreciseObjectiveCTests/[email protected] b/...ReferenceImages/_64/ImpreciseObjectiveCTests/[email protected]
diff --git a/...ges/_64/ImpreciseObjectiveCTests/[email protected] b/...ges/_64/ImpreciseObjectiveCTests/[email protected]
diff --git a/...hotTests/ReferenceImages/_64/ObjectiveCTests/[email protected] b/...hotTests/ReferenceImages/_64/ObjectiveCTests/[email protected]
diff --git a/..._64/ObjectiveCTests/[email protected] b/..._64/ObjectiveCTests/[email protected]
diff --git a/...64/ObjectiveCTests/[email protected] b/...64/ObjectiveCTests/[email protected]
diff --git a/.../_64/ObjectiveCTests/[email protected] b/.../_64/ObjectiveCTests/[email protected]
diff --git a/...Images/_64/ObjectiveCTests/[email protected] b/...Images/_64/ObjectiveCTests/[email protected]
diff --git a/..._64/ObjectiveCTests/[email protected] b/..._64/ObjectiveCTests/[email protected]
diff --git a/...hotTests/ReferenceImages/_64/ObjectiveCTests/[email protected] b/...hotTests/ReferenceImages/_64/ObjectiveCTests/[email protected]
diff --git a/...erenceImages/_64/ObjectiveCTests/[email protected] b/...erenceImages/_64/ObjectiveCTests/[email protected]
diff --git a/...Tests.AccessibilityContainersTests/[email protected] b/...Tests.AccessibilityContainersTests/[email protected]
diff --git a/...AccessibilityContainersTests/[email protected] b/...AccessibilityContainersTests/[email protected]
diff --git a/...64/SnapshotTests.AccessibilityContainersTests/[email protected] b/...64/SnapshotTests.AccessibilityContainersTests/[email protected]
diff --git a/..._64/SnapshotTests.AccessibilityContainersTests/[email protected] b/..._64/SnapshotTests.AccessibilityContainersTests/[email protected]
diff --git a/...ges/_64/SnapshotTests.AccessibilityContainersTests/[email protected] b/...ges/_64/SnapshotTests.AccessibilityContainersTests/[email protected]
diff --git a/...shotTests.AccessibilitySnapshotTests/[email protected] b/...shotTests.AccessibilitySnapshotTests/[email protected]
diff --git a/...4/SnapshotTests.AccessibilitySnapshotTests/[email protected] b/...4/SnapshotTests.AccessibilitySnapshotTests/[email protected]
diff --git a/.../SnapshotTests.AccessibilitySnapshotTests/[email protected] b/.../SnapshotTests.AccessibilitySnapshotTests/[email protected]
diff --git a/...otTests.AccessibilitySnapshotTests/[email protected] b/...otTests.AccessibilitySnapshotTests/[email protected]
diff --git a/...apshotTests.AccessibilitySnapshotTests/[email protected] b/...apshotTests.AccessibilitySnapshotTests/[email protected]
diff --git a/...bilitySnapshotTests/[email protected] b/...bilitySnapshotTests/[email protected]
diff --git a/...bilitySnapshotTests/[email protected] b/...bilitySnapshotTests/[email protected]
diff --git a/...SnapshotTests.AccessibilitySnapshotTests/[email protected] b/...SnapshotTests.AccessibilitySnapshotTests/[email protected]
diff --git a/...es/_64/SnapshotTests.AccessibilitySnapshotTests/[email protected] b/...es/_64/SnapshotTests.AccessibilitySnapshotTests/[email protected]
diff --git a/...pshotTests/testViewAsSubviewOfViewInViewControllerHierarchy_17_2_393x852@3x.png b/...pshotTests/testViewAsSubviewOfViewInViewControllerHierarchy_17_2_393x852@3x.png
diff --git a/...napshotTests.AccessibilitySnapshotTests/[email protected] b/...napshotTests.AccessibilitySnapshotTests/[email protected]
diff --git a/...ccessibilitySnapshotTests/[email protected] b/...ccessibilitySnapshotTests/[email protected]
diff --git a/...pshotTests.ActivationPointTests/[email protected] b/...pshotTests.ActivationPointTests/[email protected]
diff --git a/...tivationPointTests/[email protected] b/...tivationPointTests/[email protected]
diff --git a/...apshotTests.ActivationPointTests/[email protected] b/...apshotTests.ActivationPointTests/[email protected]
diff --git a/...ages/_64/SnapshotTests.DefaultControlsTests/[email protected] b/...ages/_64/SnapshotTests.DefaultControlsTests/[email protected]
diff --git a/..._64/SnapshotTests.DefaultControlsTests/[email protected] b/..._64/SnapshotTests.DefaultControlsTests/[email protected]
diff --git a/...nceImages/_64/SnapshotTests.DefaultControlsTests/[email protected] b/...nceImages/_64/SnapshotTests.DefaultControlsTests/[email protected]
diff --git a/...ges/_64/SnapshotTests.DefaultControlsTests/[email protected] b/...ges/_64/SnapshotTests.DefaultControlsTests/[email protected]
diff --git a/...ceImages/_64/SnapshotTests.DefaultControlsTests/[email protected] b/...ceImages/_64/SnapshotTests.DefaultControlsTests/[email protected]
diff --git a/...SnapshotTests.ElementOrderTests/[email protected] b/...SnapshotTests.ElementOrderTests/[email protected]
diff --git a/...eferenceImages/_64/SnapshotTests.ElementOrderTests/[email protected] b/...eferenceImages/_64/SnapshotTests.ElementOrderTests/[email protected]
diff --git a/...pshotTests.ElementOrderTests/[email protected] b/...pshotTests.ElementOrderTests/[email protected]
diff --git a/...renceImages/_64/SnapshotTests.ElementOrderTests/[email protected] b/...renceImages/_64/SnapshotTests.ElementOrderTests/[email protected]
diff --git a/...ests.ElementOrderTests/[email protected] b/...ests.ElementOrderTests/[email protected]
diff --git a/...hotTests.ElementOrderTests/[email protected] b/...hotTests.ElementOrderTests/[email protected]
diff --git a/...ests.ElementOrderTests/[email protected] b/...ests.ElementOrderTests/[email protected]
diff --git a/...ests.ElementSelectionTests/[email protected] b/...ests.ElementSelectionTests/[email protected]
diff --git a/...SelectionTests/[email protected] b/...SelectionTests/[email protected]
diff --git a/...pshotTests.ElementSelectionTests/[email protected] b/...pshotTests.ElementSelectionTests/[email protected]
diff --git a/...tTests.ElementSelectionTests/[email protected] b/...tTests.ElementSelectionTests/[email protected]
diff --git a/...ntSelectionTests/[email protected] b/...ntSelectionTests/[email protected]
diff --git a/...tTests.ElementSelectionTests/[email protected] b/...tTests.ElementSelectionTests/[email protected]
diff --git a/...entSelectionTests/[email protected] b/...entSelectionTests/[email protected]
diff --git a/...es/_64/SnapshotTests.ElementSelectionTests/[email protected] b/...es/_64/SnapshotTests.ElementSelectionTests/[email protected]
diff --git a/...tTests.ElementSelectionTests/[email protected] b/...tTests.ElementSelectionTests/[email protected]
diff --git a/...shotTests.ElementSelectionTests/[email protected] b/...shotTests.ElementSelectionTests/[email protected]
diff --git a/...hotTests.ElementSelectionTests/[email protected] b/...hotTests.ElementSelectionTests/[email protected]
diff --git a/...Images/_64/SnapshotTests.HighlightTests/[email protected] b/...Images/_64/SnapshotTests.HighlightTests/[email protected]
diff --git a/...ReferenceImages/_64/SnapshotTests.HighlightTests/[email protected] b/...ReferenceImages/_64/SnapshotTests.HighlightTests/[email protected]
diff --git a/...eferenceImages/_64/SnapshotTests.HighlightTests/[email protected] b/...eferenceImages/_64/SnapshotTests.HighlightTests/[email protected]
diff --git a/...Images/_64/SnapshotTests.HitTargetTests/[email protected] b/...Images/_64/SnapshotTests.HitTargetTests/[email protected]
diff --git a/...pshotTests.HitTargetTests/[email protected] b/...pshotTests.HitTargetTests/[email protected]
diff --git a/...rtColorsTests/testInvertColorsWithIdentifier_someIdentifier_17_2_393x852@3x.png b/...rtColorsTests/testInvertColorsWithIdentifier_someIdentifier_17_2_393x852@3x.png
diff --git a/...Images/_64/SnapshotTests.InvertColorsTests/[email protected] b/...Images/_64/SnapshotTests.InvertColorsTests/[email protected]
diff --git a/...4/SnapshotTests.InvertColorsTests/[email protected] b/...4/SnapshotTests.InvertColorsTests/[email protected]
diff --git a/.../ReferenceImages/_64/SnapshotTests.LayoutTests/[email protected] b/.../ReferenceImages/_64/SnapshotTests.LayoutTests/[email protected]
diff --git a/.../_64/SnapshotTests.LayoutTests/[email protected] b/.../_64/SnapshotTests.LayoutTests/[email protected]
diff --git a/...SnapshotTests.LayoutTests/[email protected] b/...SnapshotTests.LayoutTests/[email protected]
diff --git a/..._64/SnapshotTests.LayoutTests/[email protected] b/..._64/SnapshotTests.LayoutTests/[email protected]
diff --git a/...ges/_64/SnapshotTests.LayoutTests/[email protected] b/...ges/_64/SnapshotTests.LayoutTests/[email protected]
diff --git a/.../ReferenceImages/_64/SnapshotTests.LayoutTests/[email protected] b/.../ReferenceImages/_64/SnapshotTests.LayoutTests/[email protected]
diff --git a/...es/_64/SnapshotTests.LayoutTests/[email protected] b/...es/_64/SnapshotTests.LayoutTests/[email protected]
diff --git a/...s/_64/SnapshotTests.LayoutTests/[email protected] b/...s/_64/SnapshotTests.LayoutTests/[email protected]
diff --git a/...mages/_64/SnapshotTests.ModalTests/[email protected] b/...mages/_64/SnapshotTests.ModalTests/[email protected]
diff --git a/...4/SnapshotTests.ModalTests/[email protected] b/...4/SnapshotTests.ModalTests/[email protected]
diff --git a/...es/_64/SnapshotTests.ModalTests/[email protected] b/...es/_64/SnapshotTests.ModalTests/[email protected]
diff --git a/...eferenceImages/_64/SnapshotTests.ModalTests/[email protected] b/...eferenceImages/_64/SnapshotTests.ModalTests/[email protected]
diff --git a/...erenceImages/_64/SnapshotTests.ModalTests/[email protected] b/...erenceImages/_64/SnapshotTests.ModalTests/[email protected]
diff --git a/.../ReferenceImages/_64/SnapshotTests.ModalTests/[email protected] b/.../ReferenceImages/_64/SnapshotTests.ModalTests/[email protected]
diff --git a/...shotTests.SwiftUISnapshotTests/[email protected] b/...shotTests.SwiftUISnapshotTests/[email protected]
diff --git a/...mages/_64/SnapshotTests.SwiftUISnapshotTests/[email protected] b/...mages/_64/SnapshotTests.SwiftUISnapshotTests/[email protected]
diff --git a/.../_64/SnapshotTests.UserInputLabelsTests/[email protected] b/.../_64/SnapshotTests.UserInputLabelsTests/[email protected]
diff --git a/Example/SnapshotTests/SnapshotTestCase.swift b/Example/SnapshotTests/SnapshotTestCase.swift
@@ -44,6 +44,7 @@ class SnapshotTestCase: FBSnapshotTestCase {
     // MARK: - Private Static Properties
 
     private static let testedDevices = [
+        TestDeviceConfig(systemVersion: "17.2", screenSize: CGSize(width: 393, height: 852), screenScale: 3),
         TestDeviceConfig(systemVersion: "16.4", screenSize: CGSize(width: 393, height: 852), screenScale: 3),
         TestDeviceConfig(systemVersion: "14.5", screenSize: CGSize(width: 390, height: 844), screenScale: 3),
         TestDeviceConfig(systemVersion: "13.7", screenSize: CGSize(width: 375, height: 812), screenScale: 3),

diff --git a/...shotTests/__Snapshots__/SnapshotTestingTests/testHitTargets.393x852-17-2-3x.png b/...shotTests/__Snapshots__/SnapshotTestingTests/testHitTargets.393x852-17-2-3x.png
diff --git a/...otTests/__Snapshots__/SnapshotTestingTests/testInvertColors.393x852-17-2-3x.png b/...otTests/__Snapshots__/SnapshotTestingTests/testInvertColors.393x852-17-2-3x.png
diff --git a/.../__Snapshots__/SnapshotTestingTests/testMarkerColors.custom-393x852-17-2-3x.png b/.../__Snapshots__/SnapshotTestingTests/testMarkerColors.custom-393x852-17-2-3x.png
diff --git a/...__Snapshots__/SnapshotTestingTests/testMarkerColors.default-393x852-17-2-3x.png b/...__Snapshots__/SnapshotTestingTests/testMarkerColors.default-393x852-17-2-3x.png
diff --git a/...Snapshots__/SnapshotTestingTests/testRenderingMethods.false-393x852-17-2-3x.png b/...Snapshots__/SnapshotTestingTests/testRenderingMethods.false-393x852-17-2-3x.png
diff --git a/..._Snapshots__/SnapshotTestingTests/testRenderingMethods.true-393x852-17-2-3x.png b/..._Snapshots__/SnapshotTestingTests/testRenderingMethods.true-393x852-17-2-3x.png
diff --git a/...ts__/SnapshotTestingTests/testShowingActivationPoint.always-393x852-17-2-3x.png b/...ts__/SnapshotTestingTests/testShowingActivationPoint.always-393x852-17-2-3x.png
diff --git a/...ots__/SnapshotTestingTests/testShowingActivationPoint.never-393x852-17-2-3x.png b/...ots__/SnapshotTestingTests/testShowingActivationPoint.never-393x852-17-2-3x.png
diff --git a/...pshotTestingTests/testShowingActivationPoint.whenOverridden-393x852-17-2-3x.png b/...pshotTestingTests/testShowingActivationPoint.whenOverridden-393x852-17-2-3x.png
diff --git a/.../__Snapshots__/SnapshotTestingTests/testSimpleConfiguration.393x852-17-2-3x.png b/.../__Snapshots__/SnapshotTestingTests/testSimpleConfiguration.393x852-17-2-3x.png
diff --git a/...shots__/SnapshotTestingTests/testSimpleSwiftUIConfiguration.393x852-17-2-3x.png b/...shots__/SnapshotTestingTests/testSimpleSwiftUIConfiguration.393x852-17-2-3x.png
diff --git a/...otTestingTests/testSimpleSwiftUIWithScrollViewConfiguration.393x852-17-2-3x.png b/...otTestingTests/testSimpleSwiftUIWithScrollViewConfiguration.393x852-17-2-3x.png
diff --git a/...ts__/SnapshotTestingTests/testUsingMonochromeSnapshot.false-393x852-17-2-3x.png b/...ts__/SnapshotTestingTests/testUsingMonochromeSnapshot.false-393x852-17-2-3x.png
diff --git a/...ots__/SnapshotTestingTests/testUsingMonochromeSnapshot.true-393x852-17-2-3x.png b/...ots__/SnapshotTestingTests/testUsingMonochromeSnapshot.true-393x852-17-2-3x.png
diff --git a/Scripts/build.swift b/Scripts/build.swift
@@ -46,12 +46,15 @@ enum TaskError: Error {
 }
 
 enum Platform: String, CustomStringConvertible {
+	case iOS_17
 	case iOS_16
 	case iOS_14
 	case iOS_13
 
 	var destination: String {
 		switch self {
+		case .iOS_17:
+			return "platform=iOS Simulator,OS=17.2,name=iPhone 14 Pro"
 		case .iOS_16:
 			return "platform=iOS Simulator,OS=16.4,name=iPhone 14 Pro"
 		case .iOS_14: