Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SnapshotTesting: Allow users to specify precision when using accessibilityImage helper #179

Closed
nononoah opened this issue Jan 8, 2024 · 2 comments
Labels
duplicate This issue or pull request already exists

Comments

@nononoah
Copy link

nononoah commented Jan 8, 2024

Currently, users who wish to evaluate accessibility snapshots via SnapshotTesting have no convenient way of specifying the precision of that evaluation.

Since the threshold for perceptible to human eye is less than 1, it may be ideal to allow users to modify this value to one that may be less flaky in heterogeneous execution contexts.

The method in question may be found here.

I would like to add a precision parameter to this method. Without as much, users wishing to modify the precision must recreate this work in some form and use AccessibilitySnapshotView directly so that may do so themselves.

If I've missed another approach here, apologies for the noise. I'm happy to write this (small) PR myself.

@nononoah
Copy link
Author

nononoah commented Jan 8, 2024

PR opened here.

@NickEntin NickEntin added the duplicate This issue or pull request already exists label Jan 20, 2024
@NickEntin
Copy link
Collaborator

Hey Noah, this is tracked by issue #63 and has a draft PR #143 that gives some context on why we need to be careful with the way this is implemented (and why it's blocked at the moment). I'm going to close this issue and the associated PR as dupes, but let's continue any follow-up discussion on the open ones. Thanks!

@NickEntin NickEntin closed this as not planned Won't fix, can't repro, duplicate, stale Jan 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants