Support block-based accessibility properties #196
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickEntin
force-pushed
the
entin/block-based-properties
branch
4 times, most recently
from
591d591 to
8cc1486
Compare
NickEntin
force-pushed
the
entin/ios-17
branch
from
1b2f58a to
0d90140
Compare
NickEntin
force-pushed
the
entin/block-based-properties
branch
from
8cc1486 to
04f5513
Compare
NickEntin
force-pushed
the
entin/ios-17
branch
from
d9c02a4 to
b5741bb
Compare
These block-based variants of the UIAccessibility properties were introduced in iOS 17. Resolves #192.
NickEntin
force-pushed
the
entin/block-based-properties
branch
from
04f5513 to
1e0e3d9
Compare
| return isAccessibilityElementBlock?() ?? isAccessibilityElement | ||
| } else { | ||
| return isAccessibilityElement | ||
| } |
There was a problem hiding this comment.
you should remove 'else' block, you have 'return isAccessibilityElement' in the end, this is duplicate.
And in other variables same
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These block-based variants of the UIAccessibility properties were introduced in iOS 17. Resolves #192.