Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration on demand can cause problems #43

Closed
dellisd opened this issue Feb 3, 2023 · 1 comment · Fixed by #49
Closed

Configuration on demand can cause problems #43

dellisd opened this issue Feb 3, 2023 · 1 comment · Fixed by #49
Labels
bug Something isn't working

Comments

@dellisd
Copy link
Collaborator

dellisd commented Feb 3, 2023

We have a check to see if the plugin is applied to all feature modules.

With configuration on demand enabled, the feature modules may (and likely would) not be configured since the base module does not explicitly declare any dependency on the feature modules. This leads to the check failing, even when the plugin is actually being applied correctly.

@dellisd dellisd added the bug Something isn't working label Feb 3, 2023
@dellisd
Copy link
Collaborator Author

dellisd commented Feb 3, 2023

Fixing this will be a prerequisite for #35.

We'll probably have to publish the partial lockfiles as build artifacts and add feature modules as a dependency of the base module in a custom configuration.. or something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant