Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two approvals when signing a Transaction object #465

Open
1 task done
KillianH opened this issue Dec 16, 2024 · 0 comments
Open
1 task done

Two approvals when signing a Transaction object #465

KillianH opened this issue Dec 16, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@KillianH
Copy link
Contributor

Describe the bug
When signing a Transaction object and serializing it back to JSON I get two approvals instead of one.

https://github.com/casper-ecosystem/casper-js-sdk/blob/feat-5.0.0/src/types/Transaction.ts#L505

The code add a first approval to the transaction object and another one to the deploy or transactionV1 object.

To Reproduce

Identify if any Prequisites:

Steps to reproduce the behavior:

  1. Use sign() or setSignature() from the Transaction Class

Expected behavior
Signing with a single key should add a single approval ?

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context

Add a test to verify the number of approvals
https://github.com/casper-ecosystem/casper-js-sdk/blob/feat-5.0.0/src/types/Transaction.test.ts#L85

Defect Type

  • Regression
@KillianH KillianH added the bug Something isn't working label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant