We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe the bug When signing a Transaction object and serializing it back to JSON I get two approvals instead of one.
https://github.com/casper-ecosystem/casper-js-sdk/blob/feat-5.0.0/src/types/Transaction.ts#L505
The code add a first approval to the transaction object and another one to the deploy or transactionV1 object.
To Reproduce
Identify if any Prequisites:
Steps to reproduce the behavior:
Expected behavior Signing with a single key should add a single approval ?
Screenshots If applicable, add screenshots to help explain your problem.
Additional context
Add a test to verify the number of approvals https://github.com/casper-ecosystem/casper-js-sdk/blob/feat-5.0.0/src/types/Transaction.test.ts#L85
Defect Type
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Describe the bug
When signing a Transaction object and serializing it back to JSON I get two approvals instead of one.
https://github.com/casper-ecosystem/casper-js-sdk/blob/feat-5.0.0/src/types/Transaction.ts#L505
The code add a first approval to the transaction object and another one to the deploy or transactionV1 object.
To Reproduce
Identify if any Prequisites:
Steps to reproduce the behavior:
Expected behavior
Signing with a single key should add a single approval ?
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add a test to verify the number of approvals
https://github.com/casper-ecosystem/casper-js-sdk/blob/feat-5.0.0/src/types/Transaction.test.ts#L85
Defect Type
The text was updated successfully, but these errors were encountered: