Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update crates and tests to last state of art #21

Merged
merged 8 commits into from
Sep 25, 2023
Merged

Update crates and tests to last state of art #21

merged 8 commits into from
Sep 25, 2023

Conversation

gRoussac
Copy link
Contributor

Test do not compile with current crates versions so updating everything to latest.

   Compiling casper-execution-engine v2.0.1
error[E0277]: the trait bound `casper_hashing::Digest: ToBytes` is not satisfied
  --> /Users/campv/.cargo/registry/src/github.com-1ecc6299db9ec823/casper-execution-engine-2.0.1/src/storage/global_state/in_memory.rs:59:24
   |

@gRoussac gRoussac requested review from ipopescu, bpr and deuszex July 18, 2023 15:45
ipopescu
ipopescu approved these changes Jul 20, 2023
View reviewed changes
Copy link
Contributor

@ipopescu ipopescu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gRoussac! Runs fine locally, but the build is failing. make check-lint seems fine for me locally.

@ipopescu ipopescu self-requested a review July 20, 2023 14:09
deuszex
deuszex approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@deuszex deuszex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A sound update

@gRoussac gRoussac merged commit 54ed456 into master Sep 25, 2023
2 checks passed
@gRoussac gRoussac deleted the update_crates branch October 18, 2023 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deuszex deuszex deuszex approved these changes

@ipopescu ipopescu ipopescu approved these changes

@bpr bpr Awaiting requested review from bpr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gRoussac @ipopescu @deuszex