Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add update strategy to ds #89

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add update strategy to ds #89

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ea8738
Add maxUnavailable and updateStrategy to values
liorfranko Jan 4, 2024
3074739
Add updateStrategy
liorfranko Jan 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions charts/egressd/templates/collector/daemonSet.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,12 @@ spec:
selector:
matchLabels:
{{- include "egressd.selectorLabels" . | nindent 6 }}
updateStrategy:
{{- if eq .Values.collector.updateStrategy "RollingUpdate" }}
rollingUpdate:
maxUnavailable: {{ .Values.collector.maxUnavailable }}
{{- end }}
type: {{ .Values.collector.updateStrategy }}
template:
metadata:
annotations:
Expand Down
4 changes: 3 additions & 1 deletion charts/egressd/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,9 @@ collector:

# Explicitly set conntrack mode (netfilter,cilium)
ctMode: ""

updateStrategy: RollingUpdate
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not common for helm chart. Instead configure default updateStrategy for the whole object

updateStrategy:
  type: RollingUpdate
  rollingUpdate:
     maxUnavailable: 1

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean that the deployment and daemons will share the same update strategy?

maxUnavailable: 1

exporter:
image:
repository: ghcr.io/castai/egressd/egressd-exporter
Expand Down