From 2552d01b99d01d082aa8c9f21ed6e0765ed254e6 Mon Sep 17 00:00:00 2001
From: Mike Norgate <michael@cast.ai>
Date: Fri, 19 Apr 2024 11:48:12 +0100
Subject: [PATCH] Handle tri-state values in node templates

---
 castai/resource_node_template_test.go | 56 ++++++++++++++++++++++++++-
 1 file changed, 54 insertions(+), 2 deletions(-)

diff --git a/castai/resource_node_template_test.go b/castai/resource_node_template_test.go
index 1dc79907d..a77b11377 100644
--- a/castai/resource_node_template_test.go
+++ b/castai/resource_node_template_test.go
@@ -56,8 +56,6 @@ func TestNodeTemplateResourceReadContext(t *testing.T) {
 				  "spotDiversityPriceIncreaseLimitPercent": 20,
 				  "spotInterruptionPredictionsEnabled": true,
 				  "spotInterruptionPredictionsType": "aws-rebalance-recommendations",
-				  "storageOptimized": false,
-				  "computeOptimized": false,
 				  "minCpu": 10,
 				  "maxCpu": 10000,
 				  "instanceFamilies": {
@@ -388,6 +386,60 @@ func TestNodeTemplateResourceDelete_defaultNodeTemplate(t *testing.T) {
 		" false).", result[0].Detail)
 }
 
+func TestToTemplateConstraints_HandleTriStateValues(t *testing.T) {
+	tests := map[string]struct {
+		val        cty.Value
+		assertions func(*require.Assertions, *sdk.NodetemplatesV1TemplateConstraints)
+	}{
+		"all values empty except one": {
+			val: cty.ObjectVal(map[string]cty.Value{
+				FieldNodeTemplateConstraints: cty.ListVal([]cty.Value{
+					cty.ObjectVal(map[string]cty.Value{
+						FieldNodeTemplateMaxCpu: cty.NumberIntVal(100),
+					}),
+				}),
+			}),
+			assertions: func(r *require.Assertions, constraints *sdk.NodetemplatesV1TemplateConstraints) {
+				r.NotNil(constraints)
+				r.Nil(constraints.ComputeOptimized)
+				r.Nil(constraints.StorageOptimized)
+				r.Nil(constraints.Gpu)
+				r.Nil(constraints.InstanceFamilies)
+				r.Nil(constraints.MaxMemory)
+				r.Nil(constraints.MinMemory)
+				r.Nil(constraints.MinCpu)
+				r.Nil(constraints.Spot)
+				r.Nil(constraints.OnDemand)
+				r.Nil(constraints.UseSpotFallbacks)
+				r.Nil(constraints.EnableSpotDiversity)
+				r.Nil(constraints.SpotDiversityPriceIncreaseLimitPercent)
+				r.Nil(constraints.SpotInterruptionPredictionsEnabled)
+				r.Nil(constraints.SpotInterruptionPredictionsType)
+				r.Nil(constraints.CustomPriority)
+				r.Nil(constraints.DedicatedNodeAffinity)
+				r.Nil(constraints.Architectures)
+				r.Nil(constraints.Os)
+				r.Nil(constraints.IsGpuOnly)
+			},
+		},
+	}
+
+	for name, td := range tests {
+		t.Run(name, func(t *testing.T) {
+			r := require.New(t)
+			resource := resourceNodeTemplate()
+			state := terraform.NewInstanceStateShimmedFromValue(td.val, 0)
+			state.ID = "testing-template"
+
+			data := resource.Data(state)
+			constraintsArray := data.Get(FieldNodeTemplateConstraints).([]any)
+			constraintsMap := constraintsArray[0].(map[string]any)
+			result := toTemplateConstraints(constraintsMap, data)
+			td.assertions(r, result)
+		})
+	}
+}
+
 func TestAccResourceNodeTemplate_basic(t *testing.T) {
 	rName := fmt.Sprintf("%v-node-template-%v", ResourcePrefix, acctest.RandString(8))
 	resourceName := "castai_node_template.test"