Training skills that lack a lot of recipes via training the secondary skills

[RoyalFox2140]

Right now, secondary skills don't gain xp during a craft and are mainly there for autolearn and increased failure chance if you don't meet them. Allowing secondary skill requirements to train a skill would make some skills such as mechanics easier to train. First referenced in #3800

[scarf005]

i agree, we could reference DCSS's cross training

[chaosvolt]

If anyone can point to what function in the code is responsible for calling the practice function while crafting that would be a big help, I've attempted to find it in the past (for the sake of trying to sus out the rate at which crafting generates EXP per hour so I have a benchmark for what other activities should be doing to compete with craft-grinding) and failed to find it.

[scarf005]

Fields

Cataclysm-BN/src/recipe.h

Lines 111 to 112 in 04b463a

	skill_id skill_used;
	std::map<skill_id, int> required_skills;

skill_used: primary skill
required_skills: map of secondary skills

Crafting success chance

Cataclysm-BN/src/crafting.cpp

Lines 816 to 823 in 04b463a

	double player::crafting_success_roll( const recipe &making ) const
	{
	int secondary_dice = 0;
	int secondary_difficulty = 0;
	for( const auto &pr : making.required_skills ) {
	secondary_dice += get_skill_level( pr.first );
	secondary_difficulty += pr.second;
	}

Skill gain from crafting function

Cataclysm-BN/src/crafting.cpp

Line 770 in 04b463a

void player::craft_skill_gain( const item &craft, const int &multiplier )

Practicing Primary Skill

Cataclysm-BN/src/crafting.cpp

Line 790 in 04b463a

practice( making.skill_used, base_practice, skill_cap, true );

[chaosvolt]

Ayy, good shit :D

[chaosvolt]

So I assume it would be added in player::craft_skill_gain and the resulting format would look roughly like this:

     for( const auto &pr : making.required_skills ) { 
         practice( pr, base_practice * 0.5, skill_cap, true ); 
     } 

[scarf005]

i think so, but the inner logic should be tidied up first into multiple functions.

[scarf005]

i this discussion could be closed as concrete solutions are made and accepted.

• feat: secondary crafting skills gain EXP too #3921
• feat(balance): use mechanics skill in a couple low-level recipes #3932