☂️ Various features that exist in DDA but do not exist in BN

[Firestorm01X2]

Tekker#7841 prepared list of thing that exist in DDA, but does not exist in BN and vice versa.
I am creating issue because some of this thing are relatively small and it is easy to miss it.
It is good idea to review that list and port some things.

Exist in DDA but not in BN:

• Layered inventory (For now we prefer to avoid that)
• Food spoilage factors in thaw times, making food last ages longer (BN has that)
• Enemy display above minimap shows numbers of each enemy type (Definitely interesting QoL feature)
• More car part tiles ( Possible list of PR is here: Porting car parts from DDA #418 )
• Can take follower equiped items from trade menu (Nice QoL)
• Cracker sandwiches (Sounds minor, is it really provide something unique? But still.)
• Items and enemies show what mod they're from in descriptions Ported
• Books are color coded by skill/fun Ported
• Saved character presets remember what their name was (Nice QoL)

Exist in BN but non in DDA:

• Watches/sheathes/holsters automatically equip to empty side
• Read books from the ground
• Power grid
• 'E' on counters doesn't prompt crafting
• Can still use 'E' to loot (Already restored in DDA?)

### Tasks
- [ ] https://github.com/cataclysmbnteam/Cataclysm-BN/issues/2389

[TekkerSkillet]

in BN food is frozen at 32.
in DDA food is frozen at 32.
in BN food beings to rot at 33.
in DDA food is still frozen at 33 and stays that way for hours of "defrosting" time, letting it stay frozen indefinitely if the temps change back to 32 before it has thawed.

That means food in DDA, on a spring 0 start, stays frozen and not rotting for 20+ days longer than in BN.

So no, that's not already in BN.

Additional things for the list because I don't know how to use github:
DDA has
-Ladders/Stairs that go up/down on the same tile, meaning you don't have to walk to a separate ladder/stairs to climb things like radio towers and silos, you just hit up/down again.
-Keeping the Syringe from used Flu shots
-Cat Ear accessories don't take up a head slot, blocking other head wear
-Different bleed levels indicated by different coloring of the LMB, pink being light bleeding, darker reds being progressively worse bleeding.

BN has
-Showing your carrying capacity in the general HUD

[Zireael07]

BN has: foraging yielding harvest materials #1134

[chaosvolt]

My current list of things to want to mess with at some point:

• Weapon categories for mod intercompatibility (weapon_category for martial arts cross-mod compatibility CleverRaven/Cataclysm-DDA#50212, Weapon category in MA info menu CleverRaven/Cataclysm-DDA#52402, follow-up PRs that added wcategories to styles and weapons).
• Ability to refuel reloadable terrain/furniture (smokers and such) using adjacent fuel (Allow refueling smokers & furniture from tiles in pickup range CleverRaven/Cataclysm-DDA#51442).
• Leash and lead tamed animals (Leash and lead tamed animals CleverRaven/Cataclysm-DDA#50890).
• Allowing effects to block regen (Regenerating creatures don't regen while onfire CleverRaven/Cataclysm-DDA#50439), needs an actual implementation instead of source PR's half-assing it to only give it to debug monster.
• Steal the mana modifier thing for Olanti (part of [Magiclysm] Attunements - Biotek CleverRaven/Cataclysm-DDA#44357).
• Allowing NPCs to toggle on items in combat (Allow NPCs to toggle on power armor (and other things) during combat CleverRaven/Cataclysm-DDA#52259), it's a new-ish feature so will need double-checking for bugs.
• Allowing healing rate changes for any effect, not just hardcoded to bandaged and disinfected effects (Allow HEALING_RATE for any effect CleverRaven/Cataclysm-DDA#40072).
• Maybe JSONization of parking lots (Jsonify parking lot CleverRaven/Cataclysm-DDA#44933). Problem is, like we found out with mine entrances (and earlier, industrial centers), if generic parking lots are being used in an overmap special in a way where the hardcoded placement would break, chances are a single generic parking center layout isn't useful to us in that context, and it's probably better to make a custom om_terrain that fits that area instead.

Ballistic damage has since been ported over and is now removed from the wishlist.

[chaosvolt]

Another for the list: JSONized pet-taming items. CleverRaven/Cataclysm-DDA#50948

[chaosvolt]

Also potentially useful: CleverRaven/Cataclysm-DDA#53605

Question for @Ramza13 (the PR OP) though, how easy would it be to also implement the same variety to ter-turn-transform, which currently only allows terrain and furniture? Being able to look for a specific trap (or even field) and convert it to another would be extremely handy.

An alternative could be translate_ter feature, which is presently limited solely to terrain.

[chaosvolt]

We also keep running into cases where transforming mutations would be handy:
CleverRaven/Cataclysm-DDA#39523
CleverRaven/Cataclysm-DDA#40803
CleverRaven/Cataclysm-DDA#41448

[Ramza13]

Also potentially useful: CleverRaven/Cataclysm-DDA#53605

Question for @Ramza13 (the PR OP) though, how easy would it be to also implement the same variety to ter-turn-transform, which currently only allows terrain and furniture? Being able to look for a specific trap (or even field) and convert it to another would be extremely handy.

An alternative could be translate_ter feature, which is presently limited solely to terrain.

Hmm adding the ability to transform transform fields and traps sounds interesting. Might help me make my eventual nether dungeon more dynamic. I haven't looked much at the code but I don't think that sounds too hard. I'll add it to my to-do list. Edit: Just to be clear I am intending to add these things to DDA not BN but they should hopefully be easy to merge.

[chaosvolt]

Will be neat to see if you do tackle this, and feel free to link to a PR if you end up tackling it, might see if I can port it myself sometime.

EDIT: transforming traps in particular would be a good expansion of that fatigue-eating feature in the above PR in fact, as then it'd fully mimic the effects of ARTC_PORTAL, able to affect portal traps in addition to fatigue fields.

[Ramza13]

CleverRaven/Cataclysm-DDA#54491
This should handle trap and field transforms.

[chaosvolt]

Oooh, nice. I might set aside time this week to work on some of the stuff on my list of things I want to mess with porting over.

[UmbralReaper]

As of CleverRaven/Cataclysm-DDA#54216, DDA has restored negative morale for killing child zombies.

[chaosvolt]

Last I checked this feature is working in BN, so the fix is for a DDA-specific bug.

[UmbralReaper]

Last I checked this feature is working in BN, so the fix is for a DDA-specific bug.

I was referring to this dotpoint in the opening post

Killing child zombies doesn't give negative morale (Probably it is better to keep morale effect- it makes child zombies somewhat unique)

[chaosvolt]

This has no relevance to BN currently, you're talking about a feature that was only broken in DDA:

[UmbralReaper]

This has no relevance to BN currently, you're talking about a feature that was only broken in DDA

Yes. I was referring to the fact that the OP mentioned it as a feature that existed in DDA but not in BN. As the bug has been fixed in DDA, it is no longer a feature that exists in DDA but not in BN.

[DrPariah]

Eternal Day/Night: Eternal Night & Eternal Day options #53321 Eternal Weather: Eternal weather #59707
Both of these look like fun options.

there should be a way to bring back acid rain

Japanese Variant had both Acid Rain AND Acid Snow, neither being too badly broken. Probably not too hard to port them for someone with actual coding skills. EDIT: here's the link to the variant.

https://github.com/roloa/Cataclysm-DDA_variant

[scarf005]

looks like a good performance port: CleverRaven/Cataclysm-DDA#63056

[DrPariah]

CleverRaven/Cataclysm-DDA#56045
CleverRaven/Cataclysm-DDA#56203

Neat one from last year, it's a change to the music code that lets you designate playlists for things like the radio or such. Second one was a fix/update for the first.

[DrPariah]

CleverRaven/Cataclysm-DDA#49800

NPCs able to use attack spells, I could see multiple uses for this.

[Zireael07]

CleverRaven/Cataclysm-DDA#65478

Recent change worth porting

[Lamandus]

CleverRaven/Cataclysm-DDA#65478

Recent change worth porting

A lot of pseudo stuff going on, and the new forest floor thing doesn't seem to add a lot other than bloat

[SurFlurer]

CleverRaven/Cataclysm-DDA#57193 Enjoy the advancement of battery technology.

[DrPariah]

WhiteCloud0123/CDDA-Breeze#115

Not from mainline C:DDA, this is from the CDDA Breeze branch. Allows mounts to go up and down stairs. I don't think we have this.

[DrPariah]

CleverRaven/Cataclysm-DDA#62439
CleverRaven/Cataclysm-DDA#62408

There was a casual question in the Discord that got me to look these up. The top one is about additional traits for NPCs that make sure they don't bash things en route to pathing to them, returning to their start POS once they do, and an additional one for allowing NPCs to just plain not bother to investigate weird sounds at all.

The second one is for NPCs just plain not moving at all. This isn't near as useful for the intended goal (keeping NPCs from breaking everything and anything in their path en route to find out who said something just outside of their field of view), because it causes some other undesired behaviors (NPCs who don't fight back at all when attacked is one of them), but it seems like it could have some other very useful applications.

[DrPariah]

WhiteCloud0123/CDDA-Breeze#151

Monsters that can equip weapons, from the Breeze fork of C:DDA.

[chaosvolt]

Two things Boophis brought up in DMs:

1. add spellcasting npc attack CleverRaven/Cataclysm-DDA#49800 (spellcasting NPC extension)
2. Games with friends CleverRaven/Cataclysm-DDA#51981 and Games with Friends - Part 2 CleverRaven/Cataclysm-DDA#52381 (playing games with NPC companions, relevant items may need to be ported over too)

[DrPariah]

CleverRaven/Cataclysm-DDA#51739

This looks like a VERY useful PR, allowing conversations with monsters and (most importantly) items. This would allow us to use maps/journals/etc. for quests without having to use a SPAWN_NPC item (though that is still a viable option and very appropriate in certain cases like the holograms).

[chaosvolt]

Possible performance improvement, thanks to @Maleclypse for bringing my attention to it in the discord: CleverRaven/Cataclysm-DDA#67403

[scarf005]

would be great for modding.
CleverRaven/Cataclysm-DDA#66623

btw we should really make use of tasklist and project board someday to track what's done and undone.

[RoyalFox2140]

Nested crafting categories could condense the crafting menu a ton especially for mods that add a lot of similar items like extra medieval weaponry. CleverRaven/Cataclysm-DDA#59924