Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Armor portion data can't be overriden by item inheritance #5757

Open
chaosvolt opened this issue Nov 24, 2024 · 1 comment
Open

Armor portion data can't be overriden by item inheritance #5757

chaosvolt opened this issue Nov 24, 2024 · 1 comment
Labels
bug confirmed Bug that has been reproduced src changes related to source code.

Comments

@chaosvolt
Copy link
Member

Describe the bug

I finally started to test applying armor power data to something since we haven't really used it for anything in-repo yet, and the first thing I looked at was to see about applying it to a transforming armor item, so of course that meant copy the armor portion data but have lower encumbrance when activated...leading to load errors:
image

Steps To Reproduce

  1. Add an item that inherits via copy-from from the debug SWAT armor in testing data mod.
  2. Give it an override to armor portion data, covering the same bodyparts but if desired changing coverage percent and/or encumbrance.
  3. Load-test a world with testing mod enabled.

Screenshots

No response

Versions and configuration

  • OS: Windows
    • OS Version: 10.0.19041.450 (2004)
  • Game Version: v2024.11.21 [64-bit]
  • Graphics Version: Tiles
  • LAPI Version: 2
  • Game Language: []
  • Mods loaded: [
    Bright Nights [bn],
    Arcana and Magic Items [Arcana],
    Cataclysm++ [Cata++],
    Item Category Overhaul [Item_Category_Overhaul],
    Pride Flags for BN [pride_flags],
    Medieval Mod Reborn [Medieval_Mod_Reborn],
    MST Extra [MST_Extra],
    Arcana/Cata++ Patchmod [Arcana_Cata++_Patch],
    Mining Mod [Mining_Mod],
    Tankmod: Revived [Tankmod_Revived],
    No Fungal Monsters [No_Fungi],
    Disable NPC Needs [no_npc_food],
    Faster Stamina Regen [stamina_regen_buff],
    Manual Bionic Installation [manualbionicinstall],
    Simplified Nutrition [novitamins],
    SpeedyDex [speedydex],
    Stats Through Kills [stats_through_kills]
    ]

Additional context

The item I was testing trying to add armor portion data was in Cata++: https://github.com/Noctifer-de-Mortem/nocts_cata_mod/blob/master/nocts_cata_mod_BN/Surv_help/c_armor.json#L1012

Idea was gonna be to make the torso have 100% coverage but the highest encumbrance, eyes/head/mouth a bit lower coverage, and limbs the coverage value it currently has, so that it can still have weak points to get chipped down while being more reliable for protecting the vitals against ranged attacks.

@chaosvolt chaosvolt added the bug label Nov 24, 2024
@RoyalFox2140 RoyalFox2140 added confirmed Bug that has been reproduced src changes related to source code. labels Dec 6, 2024
@Coolthulhu
Copy link
Member

Weirdly, if you override some of the parts, it doesn't bug out, but instead overrides others as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug confirmed Bug that has been reproduced src changes related to source code.
Projects
None yet
Development

No branches or pull requests

3 participants