Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extra_effects spells with summon effect always get casted regardless of restrictions #5785

Open
Ignaramico opened this issue Dec 3, 2024 · 1 comment
Labels
bug src changes related to source code.

Comments

@Ignaramico
Copy link

Describe the bug

tried to make a custom spell using as base the secronom infect flesh spell, noticed how regardless of the restrictions the extra_effect spells with the summon effect always get casted regardless of the targeted id, but the spells that does damage doesnt

Steps To Reproduce

give/copy the secronom "mon_flesh_infect_target" spell and make it player castable
check how you get like 80+ "failed to place monster" message but not the same problem with the damage spell (you notice how the spel isnt casted because target is still alive)

Screenshots

No response

Versions and configuration


15:53:43.943 : Starting log.
15:53:43.943 INFO : Cataclysm BN version ac7253c 64-bit
15:53:43.944 INFO : C locale on startup: 'C'
15:53:43.944 INFO : C++ locale on startup: 'C'
15:53:43.978 INFO : Detected system UI language as 'en_US'
15:53:43.978 INFO : SDL version used during compile is 2.26.2
15:53:43.978 INFO : SDL version used during linking and in runtime is 2.26.2
15:53:47.428 INFO : Number of render drivers on your system: 6
15:53:47.428 INFO : Render driver: 0/direct3d
15:53:47.428 INFO : Render driver: 1/direct3d11
15:53:47.428 INFO : Render driver: 2/direct3d12
15:53:47.428 INFO : Render driver: 3/opengl
15:53:47.428 INFO : Render driver: 4/opengles2
15:53:47.428 INFO : Render driver: 5/software
15:53:47.457 INFO : Set debug classes to: [DEBUGMSG MAIN LUA]
15:53:48.003 INFO : Active renderer: 3/opengl
15:53:49.137 INFO : Active audio driver: wasapi
15:53:49.171 INFO : Opened mixer with specs: 44100 Hz, 2 channel(s), format 0x8010
15:53:49.697 INFO : Language set to 'en_US'
15:53:49.697 INFO : C locale set to 'English_United States.1252'
15:53:49.697 INFO : C++ locale set to 'C'
15:53:51.802 INFO : LAPI version: 2
15:53:51.828 INFO LUA : Lua online.
15:54:43.386 INFO : Loaded tileset: UNDEAD_PEOPLE_BASE
15:55:20.520 INFO : GAME REPORT:

  • OS: Windows
    • OS Version: MINGW/CYGWIN/MSYS2 on unknown Windows version
  • Game Version: ac7253c [64-bit]
  • Graphics Version: Tiles
  • LAPI Version: 2
  • Game Language: English [en_US]
  • Mods loaded: [
    Bright Nights [bn],
    Disable NPC Needs [no_npc_food],
    Simplified Nutrition [novitamins],
    No Rail Stations [No_Rail_Stations],
    Prevent Zombie Revivication [no_reviving_zombies],
    Limit Fungal Growth [limit_fungal_growth],
    Item Category Overhaul [Item_Category_Overhaul],
    UDP Redux [udp_redux],
    A dueliste mod [Aduelistmmod]
    ]

15:55:28.839 : Log shutdown.

Additional context

again all the extra effects are being casted regardless of the targeted ids, since the dmg spell has the summon spell as an extra effect, so instead of stopping the process altogether (like with the dmg since it isnt a valid target) it still jumps to the extra effect spell

@Ignaramico Ignaramico added the bug label Dec 3, 2024
@RoyalFox2140 RoyalFox2140 added the src changes related to source code. label Dec 6, 2024
@Ignaramico
Copy link
Author

as extra info, the same happens if you use "target_attack" and "effect_str" instead, all the effects gets applied

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug src changes related to source code.
Projects
None yet
Development

No branches or pull requests

2 participants