14 error display #22
Draft
14 error display #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeteCoward
commented
Aug 3, 2020
| reject(err.message, err) | ||
| // 598 (Informal convention) Network read timeout error | ||
| // used here to indicate generic failure | ||
| reject(598) |
There was a problem hiding this comment.
not really decided what to send back here, code -1, string 'fetch error'?
PeteCoward
commented
Aug 3, 2020
| @@ -83,6 +89,7 @@ export default async function initialise(config) { | |||
|
|
|||
| // what happens when a key is hit in the input | |||
| inputElement.onkeyup = function(e) { | |||
| inputElement.setCustomValidity(''); | |||
There was a problem hiding this comment.
This is the main reason this PR is still draft. It clears the validation on input, but causes an ugly flicker on submission with enter :/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #14
Allows configuring of 401, 403, 412, unknown error messages, and displays those messages to the user through the standard browser form validation UI.
Adds some backend submit endpoints that are just useful for developing this component, logging requests, and storing things in the cache, this part is very much not designed for use in production!