Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop travis, python 3.6/3.7 #2186

Merged
merged 6 commits into from
Dec 29, 2021
Merged

Drop travis, python 3.6/3.7 #2186

merged 6 commits into from
Dec 29, 2021

Conversation

clbarnes
Copy link
Contributor

@clbarnes clbarnes commented Dec 21, 2021

Should leave CI to run just so we know pypy3.8 is working.

@clbarnes
Copy link
Contributor Author

clbarnes commented Dec 21, 2021

The blocker here is that aggdraw doesn't install on pypy3.8, although it will on pypy3.7 and CPython 3.8. Issue raised here pytroll/aggdraw#80 but the response to most of the open issues has been that they're unlikely to get to them any time soon.

Do we get a lot of value out of pypy support? It's a bit of a maintenance burden in terms of conditional dependencies and CI build time; I know it's faster for some types of operation, but is CATMAID actually deployed on pypy anywhere?

@tomka
Copy link
Contributor

tomka commented Dec 28, 2021

The blocker here is that aggdraw doesn't install on pypy3.8, although it will on pypy3.7 and CPython 3.8. Issue raised here pytroll/aggdraw#80 but the response to most of the open issues has been that they're unlikely to get to them any time soon.

Thanks for raising the issue with aggdraw! I don't think it's a real blocker though. We can just make it conditional for PyPy in general, like we do with some other dependencies. It is only used for server-side rendering of tracing data. If it isn't installed we can just output a warning and let admins know that their configuration doesn't support this feature. And I don't think this feature is actually used anywhere.

Do we get a lot of value out of pypy support? It's a bit of a maintenance burden in terms of conditional dependencies and CI build time; I know it's faster for some types of operation, but is CATMAID actually deployed on pypy anywhere?

I don't think there are any production servers that run on PyPy. While I don't mind the conditional dependencies, the CI build times are annoying (and unneeded). So how about we remove this from CI and keep the conditional dependencies for now?

Server-side node rendering is not very common and it should be fine to
exclude it by default. It currently does not compile with PyPy 3.8.

See #2186
tomka added a commit that referenced this pull request Dec 29, 2021
This is done due to the long runtimes when PyPy is used on GitHub's CI
infrastructure.

See #2186
@tomka
Copy link
Contributor

tomka commented Dec 29, 2021

All tests in dev apart from Python 3.6 are green again and the Django 3.2 upgrade looks done. Therefore I think it is okay to merge this branch and drop support for Python 3.6 now. Regarding PyPy: I just removed it from CI, but kept the rest as documentation there, at least for now.

@tomka tomka merged commit af340f9 into dev Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants