-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop travis, python 3.6/3.7 #2186
Conversation
The blocker here is that aggdraw doesn't install on pypy3.8, although it will on pypy3.7 and CPython 3.8. Issue raised here pytroll/aggdraw#80 but the response to most of the open issues has been that they're unlikely to get to them any time soon. Do we get a lot of value out of pypy support? It's a bit of a maintenance burden in terms of conditional dependencies and CI build time; I know it's faster for some types of operation, but is CATMAID actually deployed on pypy anywhere? |
Thanks for raising the issue with aggdraw! I don't think it's a real blocker though. We can just make it conditional for PyPy in general, like we do with some other dependencies. It is only used for server-side rendering of tracing data. If it isn't installed we can just output a warning and let admins know that their configuration doesn't support this feature. And I don't think this feature is actually used anywhere.
I don't think there are any production servers that run on PyPy. While I don't mind the conditional dependencies, the CI build times are annoying (and unneeded). So how about we remove this from CI and keep the conditional dependencies for now? |
Server-side node rendering is not very common and it should be fine to exclude it by default. It currently does not compile with PyPy 3.8. See #2186
This is done due to the long runtimes when PyPy is used on GitHub's CI infrastructure. See #2186
All tests in |
Should leave CI to run just so we know pypy3.8 is working.