Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[server] add basic game submissions #164

Merged
merged 4 commits into from
May 31, 2022
Merged

[server] add basic game submissions #164

merged 4 commits into from
May 31, 2022

Conversation

waleko
Copy link
Member

@waleko waleko commented May 28, 2022

No description provided.

@waleko waleko requested review from petrtsv and MarkTheHopeful May 28, 2022 19:58
@waleko waleko self-assigned this May 28, 2022
@gitpod-io
Copy link

gitpod-io bot commented May 28, 2022

@waleko waleko marked this pull request as ready for review May 28, 2022 21:17
@waleko
Copy link
Member Author

waleko commented May 28, 2022

пока только умеет загружать. просмотра пока нет, потому что не хочется больше тратить время на фронт...

@MarkTheHopeful
Copy link
Contributor

Кстати, а где это протестить можно?

Copy link
Contributor

@MarkTheHopeful MarkTheHopeful left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ну там что-то поквакал с какими-то вопросами, но вообще хотелось бы протестить как-нибудь

@@ -5,7 +5,7 @@ set -eo pipefail
mkdir -p "$MNT_DIR"

echo "Mounting GCS Fuse."
gcsfuse --debug_gcs --debug_fuse --file-mode=005 "$BUCKET" "$MNT_DIR"
gcsfuse --debug_gcs --debug_fuse --file-mode=777 "$BUCKET" "$MNT_DIR"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ого! Полные разрешения всем на всё! А это точно окей?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

это для Google Cloud Storage. Ему теперь придётся читать, запускать и писать (собственно загружать файлы)... Поэтому можно 007, ну либо отдельно пользователя выделять. Не хотел этим заниматься в контейнере

@@ -178,3 +178,4 @@ local_server/
# Drogon logs
*.log
/games/codenames/client/client.zip
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Кстати, а зачем тут слеш в начале строки?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

хз

@@ -146,7 +147,7 @@
"br_static": true,
//client_max_body_size: Set the maximum body size of HTTP requests received by drogon. The default value is "1M".
//One can set it to "1024", "1k", "10M", "1G", etc. Setting it to "" means no limit.
"client_max_body_size": "1M",
"client_max_body_size": "128M",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

А сколько у нас в среднем QML-ка весит с серверной частью?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

40кб.........

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rzhek 🤷

server/db/schema.sql Show resolved Hide resolved
@waleko waleko merged commit 12c69f9 into develop May 31, 2022
@waleko waleko deleted the feature/game-submit branch May 31, 2022 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants