-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[server] add basic game submissions #164
Conversation
пока только умеет загружать. просмотра пока нет, потому что не хочется больше тратить время на фронт... |
Кстати, а где это протестить можно? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ну там что-то поквакал с какими-то вопросами, но вообще хотелось бы протестить как-нибудь
@@ -5,7 +5,7 @@ set -eo pipefail | |||
mkdir -p "$MNT_DIR" | |||
|
|||
echo "Mounting GCS Fuse." | |||
gcsfuse --debug_gcs --debug_fuse --file-mode=005 "$BUCKET" "$MNT_DIR" | |||
gcsfuse --debug_gcs --debug_fuse --file-mode=777 "$BUCKET" "$MNT_DIR" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ого! Полные разрешения всем на всё! А это точно окей?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
это для Google Cloud Storage. Ему теперь придётся читать, запускать и писать (собственно загружать файлы)... Поэтому можно 007, ну либо отдельно пользователя выделять. Не хотел этим заниматься в контейнере
@@ -178,3 +178,4 @@ local_server/ | |||
# Drogon logs | |||
*.log | |||
/games/codenames/client/client.zip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Кстати, а зачем тут слеш в начале строки?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
хз
@@ -146,7 +147,7 @@ | |||
"br_static": true, | |||
//client_max_body_size: Set the maximum body size of HTTP requests received by drogon. The default value is "1M". | |||
//One can set it to "1024", "1k", "10M", "1G", etc. Setting it to "" means no limit. | |||
"client_max_body_size": "1M", | |||
"client_max_body_size": "128M", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
А сколько у нас в среднем QML-ка весит с серверной частью?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
40кб.........
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rzhek 🤷
No description provided.