perf: disable SA checking in shards

If the shards and coordinators sit inside the secure perimeter, and
the coordinator is trusted to validate sentinel attestations honestly,
the shard is just duplicating effort for no benefit by checking them.

Signed-off-by: Sam Stuewe <[email protected]>

Author: HalosGhost

src/uhs/twophase/locking_shard/controller.cpp

@@ -206,22 +206,8 @@ namespace cbdc::locking_shard {
         if(maybe_req) {
             valid = std::visit(
                 overloaded{
-                    [&](rpc::lock_params&& params) -> bool {
-                        auto result = true;
-                        for(auto&& t : params) {
-                            if(!transaction::validation::check_attestations(
-                                   t.m_tx,
-                                   m_opts.m_sentinel_public_keys,
-                                   m_opts.m_attestation_threshold)) {
-                                m_logger->warn(
-                                    "Received invalid compact transaction",
-                                    to_string(t.m_tx.m_id));
-                                result = false;
-                                break;
-                            }
-                        }
-
-                        return result;
+                    [&](rpc::lock_params&&) -> bool {
+                        return true;
                     },
                     [&](rpc::apply_params&&) -> bool {
                         return true;