Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reformat / re-indent external interfaces, .h files, core src/ files for improved readability & coding standards. #142

Open
gapisback opened this issue Jul 6, 2023 · 0 comments
Open

Reformat / re-indent external interfaces, .h files, core src/ files for improved readability & coding standards. #142

gapisback opened this issue Jul 6, 2023 · 0 comments
Assignees
@gapisback
Labels
code-cleanup Minor code cleanup changes, to simplify, improve code. No logic changes.

Comments

@gapisback
Copy link
Collaborator

Refactor external .h files, interfaces and definitions in key src/ files to adhere more closer to coding standards.
Specifically:

  • Indentation of parameter lists on function declarations and definitions. (Wrap-around, 80-col limit.)
  • Document external interfaces
  • General refactoring / cleanup on these lines.

This issue is logged based on an internal email exchange w/ core CC-dev team.
@gapisback gapisback self-assigned this Jul 6, 2023
@gapisback gapisback added the code-cleanup Minor code cleanup changes, to simplify, improve code. No logic changes. label Jul 6, 2023
gapisback added a commit that referenced this issue Jul 11, 2023
@gapisback
(#142) Document Certifier APIs in .h files. Refactor code. Add unit-t…
d6121f7 
…ests

This commit started off as an exercise to document external APIs of
the Certifier Framework library. It ended up as:

- Add prologs to core extern APIs. Doc parameters
- Refactor code formatting & indentaction of extern API interfaces and
  definitions to conform closer to coding standard
- Add new unit-test in store_tests.cc, test_policy_store_signed_claims(),
  to exercise policy-store interfaces handling signed_claims.
gapisback added a commit that referenced this issue Jul 11, 2023
@gapisback
(#142) Document Certifier APIs in .h files. Refactor code. Add unit-t…
7027db3 
…ests

This commit started off as an exercise to document external APIs of
the Certifier Framework library. It ended up as:

- Add prologs to core extern APIs. Doc parameters
- Refactor code formatting & indentation of extern API interfaces and
  definitions to conform closer to coding standard
- Add new unit-test in store_tests.cc, test_policy_store_signed_claims(),
  to exercise policy-store interfaces handling signed_claims.
gapisback added a commit that referenced this issue Jul 11, 2023
@gapisback
(#142) Document Certifier APIs in .h files. Refactor code. Add unit-t…
3381401 
…ests

This commit started off as an exercise to document external APIs of
the Certifier Framework library. It ended up as:

- Add prologs to core extern APIs. Doc parameters
- Refactor code formatting & indentation of extern API interfaces and
  definitions to conform closer to coding standard
- Add new unit-test in store_tests.cc, test_policy_store_signed_claims(),
  to exercise policy-store interfaces handling signed_claims.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gapisback gapisback

Labels
code-cleanup Minor code cleanup changes, to simplify, improve code. No logic changes.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gapisback