Resolve warnings seen in SWIG generation reporting use of Python keywords and name conflicts. Re-enable -Werror flag. #155
Labels
code-cleanup
Minor code cleanup changes, to simplify, improve code. No logic changes.
With the introduction of new policy_store (under PR #151) and the integration with SWIG-support to generate Python bindings (PR #144), we are now seeing warnings generated from the
make
step that issuesswig
. Here is an example:During dev of the Python bindings, swig was invoked with
-Wall -Werror
flags. Due to the use of-Werror
flag, above warnings caused the build to fail.A short-term workaround has been implemented in
src/certifier.mak
to not use-Werror
. We do get the warning messages, but the build itself succeeds with 0 $rc.Longer-term, it is better to use both flags, so that any Python / C++ wrapper integration issues are spotted and caught early on.
We need to resolve above warnings so that
-Werror
can be re-enabled.---- (7/20/2023: Update) Another issue seem due to name of
print()
method is this pylint error:A w/a fix for this has been implemented in build.yml to use
pylint --disable W0212
. That can be removed once this name-issue is resolved.Potential solutions, some need to be further investigated:
-Werror
.print_entry()
andprint_store()
.entry_type()
andentry_tag()
The text was updated successfully, but these errors were encountered: