From 5702fc81d056ee9ee05df637f1d193e38ad13f6f Mon Sep 17 00:00:00 2001
From: Yening Qin <710leo@gmail.com>
Date: Wed, 18 Dec 2024 17:00:18 +0800
Subject: [PATCH] refactor: group delete check (#2368)

Co-authored-by: Xu Bin <140785332+Reditiny@users.noreply.github.com>
---
 models/busi_group.go | 65 +++++++++++++++++++++++++++++---------------
 1 file changed, 43 insertions(+), 22 deletions(-)

diff --git a/models/busi_group.go b/models/busi_group.go
index 56d95d4da..d4c011d0d 100644
--- a/models/busi_group.go
+++ b/models/busi_group.go
@@ -115,53 +115,74 @@ func BusiGroupExists(ctx *ctx.Context, where string, args ...interface{}) (bool,
 	return num > 0, err
 }
 
-var entries = []struct {
-	entry        interface{}
-	errorMessage string
-}{
+// RegisterGroupDelCheckEntries 提供给外部注册删除 group 时需要检查的表
+func RegisterGroupDelCheckEntries(e []CheckEntry) {
+	entries = append(entries, e...)
+}
+
+type CheckEntry struct {
+	Entry        interface{}
+	ErrorMessage string
+	FieldName    string
+}
+
+var entries = []CheckEntry{
+	{
+		Entry:        &AlertRule{},
+		ErrorMessage: "Some alert rules still in the BusiGroup",
+		FieldName:    "group_id",
+	},
 	{
-		entry:        &AlertRule{},
-		errorMessage: "Some alert rules still in the BusiGroup",
+		Entry:        &AlertMute{},
+		ErrorMessage: "Some alert mutes still in the BusiGroup",
+		FieldName:    "group_id",
 	},
 	{
-		entry:        &AlertMute{},
-		errorMessage: "Some alert mutes still in the BusiGroup",
+		Entry:        &AlertSubscribe{},
+		ErrorMessage: "Some alert subscribes still in the BusiGroup",
+		FieldName:    "group_id",
 	},
 	{
-		entry:        &AlertSubscribe{},
-		errorMessage: "Some alert subscribes still in the BusiGroup",
+		Entry:        &Board{},
+		ErrorMessage: "Some Board still in the BusiGroup",
+		FieldName:    "group_id",
 	},
 	{
-		entry:        &Target{},
-		errorMessage: "Some targets still in the BusiGroup",
+		Entry:        &Target{},
+		ErrorMessage: "Some targets still in the BusiGroup",
+		FieldName:    "group_id",
 	},
 	{
-		entry:        &RecordingRule{},
-		errorMessage: "Some recording rules still in the BusiGroup",
+		Entry:        &RecordingRule{},
+		ErrorMessage: "Some recording rules still in the BusiGroup",
+		FieldName:    "group_id",
 	},
 	{
-		entry:        &TaskTpl{},
-		errorMessage: "Some recovery scripts still in the BusiGroup",
+		Entry:        &TaskTpl{},
+		ErrorMessage: "Some recovery scripts still in the BusiGroup",
+		FieldName:    "group_id",
 	},
 	{
-		entry:        &TaskRecord{},
-		errorMessage: "Some Task Record records still in the BusiGroup",
+		Entry:        &TaskRecord{},
+		ErrorMessage: "Some Task Record records still in the BusiGroup",
+		FieldName:    "group_id",
 	},
 	{
-		entry:        &TargetBusiGroup{},
-		errorMessage: "Some target busigroups still in the BusiGroup",
+		Entry:        &TargetBusiGroup{},
+		ErrorMessage: "Some target busigroups still in the BusiGroup",
+		FieldName:    "group_id",
 	},
 }
 
 func (bg *BusiGroup) Del(ctx *ctx.Context) error {
 	for _, e := range entries {
-		has, err := Exists(DB(ctx).Model(e.entry).Where("group_id=?", bg.Id))
+		has, err := Exists(DB(ctx).Model(e.Entry).Where(fmt.Sprintf("%s=?", e.FieldName), bg.Id))
 		if err != nil {
 			return err
 		}
 
 		if has {
-			return errors.New(e.errorMessage)
+			return errors.New(e.ErrorMessage)
 		}
 	}