Use all-cabal-hashes directly rather than extracting individual components #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nents This gives us a significant speed-up, since all we need to do as part of the IFD is run cabal2nix.
|
Hey, sorry I haven't gotten to this yet. I think this looks interesting, but I haven't really be able to do an in-depth review. I might not be able to really get to this for another month or so. Sorry to keep you waiting longer! |
|
Don't worry about it at all! There's no rush |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives us a significant speed-up, since all we need to do as part of the IFD is run cabal2nix.
This is slightly simpler than the some-cabal-hashes approach, but still speeds things up considerably for me. We are still doing a bunch of IFD to generate the cabal2nix files, but it goes pretty quickly. I still feel like something like the some-cabal-hashes thing is the right thing to do, but it's a bit more work than I have capacity for right now.
The downside is that now we require all-cabal-hashes to be an unpacked directory. I could add something to enforce this, eg, a derivation that unpacks it if it's a tarball (is there a utility to do this)?
What do you think?