Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cli.test.ts may fail on Mac/Windows #1645

Merged
merged 2 commits into from
Nov 25, 2024
Merged

chore: cli.test.ts may fail on Mac/Windows #1645

merged 2 commits into from
Nov 25, 2024

Commits on Nov 19, 2024

  1. test: support process.execPath with spaces 

    When using NodeJS version managers like [nvm](https://github.com/nvm-sh/nvm) or [fnm](https://github.com/Schniz/fnm), the NodeJS binary location can be a bit "funny".

For example on macOS with fnm, the NodeJS binary path may contain folder `Application Support` which has a space in it.

Wrapping the process.execPath interpolated value into quotes solves this.
    @aripalo
    aripalo committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    fa033c8 View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2024

  1. Merge branch 'main' into fix-cli-test-execpath-with-spaces

    @iliapolo
    iliapolo authored Nov 25, 2024
    Configuration menu
    Copy the full SHA
    2f894e6 View commit details
    Browse the repository at this point in the history