Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webhook support #114

Closed
WyriHaximus opened this issue May 29, 2021 · 5 comments
Closed

Webhook support #114

WyriHaximus opened this issue May 29, 2021 · 5 comments
Milestone

Comments

@WyriHaximus
Copy link

I'm aware of #101 but wanted to file this separately since it's a new feature and not a spec upgrade. OAS 3.1 supports webhooks. Would you be open to a PR adding that, and if so give me some pointers so I can start working on that?

@cebe
Copy link
Owner

cebe commented Jun 1, 2021

I have not taken a look into what exactly needs to be changed to support OAS 3.1, but somehow spec objects need to know which version of the spec they are representing and based on that enable the new feature.

If you want to work on that, I am happy to receive a PR.

@cebe cebe added this to the 1.6.0 milestone Jun 1, 2021
@WyriHaximus
Copy link
Author

Ok awesome will have a go at it. Already using this package to parse a spec with webhooks, but having webhook support in here will also enable using a validator to pick the correct entity from the webhook call 🎉

@WyriHaximus
Copy link
Author

Opened #115 as WIP to add this, probably also contains some changes that handle the 3.0 vs 3.1 detections + the 3.1 spec files

@cebe cebe modified the milestones: 1.6.0, 1.7.0 Feb 9, 2022
@cebe cebe modified the milestones: 1.7.0, 1.8.0 Apr 20, 2022
@cebe cebe mentioned this issue Apr 20, 2022
3 tasks
@shulard
Copy link

shulard commented Oct 8, 2022

Hey !

Since #115 has been merged, should we close this one ?

@WyriHaximus
Copy link
Author

Yup, been able to use it with webhooks for some time now 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants