Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider renaming job #96

Closed
rootulp opened this issue Mar 15, 2024 · 0 comments · Fixed by #97
Closed

Consider renaming job #96

rootulp opened this issue Mar 15, 2024 · 0 comments · Fixed by #97

Comments

@rootulp
Copy link
Contributor

rootulp commented Mar 15, 2024

Context

- name: Build and Push
uses: docker/build-push-action@v5
env:
OUTPUT_SHORT_SHA: ${{ needs.prepare-env.outputs.output_short_sha }}
OUTPUT_IMAGE_NAME: ${{ needs.prepare-env.outputs.output_image_name }}
with:
context: .
push: false

Problem

I got confused because I thought this step would push a Docker image but push is hard-coded to false

Proposal

If this step never pushes a docker image, proposal to remove "and Push" from the name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant