Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cip-13: add v2 params #204

Closed
1 task
rootulp opened this issue Sep 11, 2024 · 1 comment · Fixed by #259
Closed
1 task

cip-13: add v2 params #204

rootulp opened this issue Sep 11, 2024 · 1 comment · Fixed by #259
Assignees

Comments

@rootulp
Copy link
Collaborator

rootulp commented Sep 11, 2024

Context

celestia-app app version 2 is expected to be activated on Mainnet on September 18.

Problem

https://github.com/celestiaorg/CIPs/blob/main/cips/cip-13.md is a living document so I think the intention was that it should be updated to reflect the values of params on mainnet.

Since app version 2 introduces new params (ICA, PFM, minfee), cip-13 will need to be udpated.

Proposal

Option A

Deprecate CIP-13 in favor of referencing https://celestiaorg.github.io/celestia-app/parameters.html

Option B

Update CIP-13 to add new params introduced by app version 2.

@jcstein
Copy link
Member

jcstein commented Oct 19, 2024

In favor of Option A, because it's already always documented at https://celestiaorg.github.io/celestia-app/parameters.html

@rootulp rootulp self-assigned this Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants