From a22a8100416d6d4c2f55a5a2aaf263ae2704ea10 Mon Sep 17 00:00:00 2001 From: Evan Forbes <42654277+evan-forbes@users.noreply.github.com> Date: Thu, 25 Aug 2022 15:37:43 -0500 Subject: [PATCH] Apply suggestions from code review review feedback Co-authored-by: Rootul Patel --- pkg/shares/message_shares_test.go | 6 +++--- pkg/shares/split_contiguous_shares.go | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/pkg/shares/message_shares_test.go b/pkg/shares/message_shares_test.go index e281ce9d4f..db4e9485d9 100644 --- a/pkg/shares/message_shares_test.go +++ b/pkg/shares/message_shares_test.go @@ -35,8 +35,8 @@ func Test_parseMsgShares(t *testing.T) { for _, tc := range tests { tc := tc - // run the tests with identically sized messagses - t.Run(fmt.Sprintf("%s idendically sized ", tc.name), func(t *testing.T) { + // run the tests with identically sized messages + t.Run(fmt.Sprintf("%s identically sized ", tc.name), func(t *testing.T) { rawmsgs := make([]coretypes.Message, tc.msgCount) for i := 0; i < tc.msgCount; i++ { rawmsgs[i] = generateRandomMessage(tc.msgSize) @@ -52,7 +52,7 @@ func Test_parseMsgShares(t *testing.T) { t.Error(err) } - // check that the namesapces and data are the same + // check that the namespaces and data are the same for i := 0; i < len(msgs.MessagesList); i++ { assert.Equal(t, msgs.MessagesList[i].NamespaceID, parsedMsgs[i].NamespaceID) assert.Equal(t, msgs.MessagesList[i].Data, parsedMsgs[i].Data) diff --git a/pkg/shares/split_contiguous_shares.go b/pkg/shares/split_contiguous_shares.go index c0d08cb9d2..ff3fc32ab0 100644 --- a/pkg/shares/split_contiguous_shares.go +++ b/pkg/shares/split_contiguous_shares.go @@ -19,7 +19,7 @@ type ContiguousShareSplitter struct { namespace namespace.ID } -// NewContiguousShareSplitter returns a ContigousShareWriter using the provided +// NewContiguousShareSplitter returns a ContiguousShareSplitter using the provided // namespace. func NewContiguousShareSplitter(ns namespace.ID) *ContiguousShareSplitter { pendingShare := NamespacedShare{ID: ns, Share: make([]byte, 0, consts.ShareSize)}