From e61f23029e5d195d679294ba03e995fb628ac36e Mon Sep 17 00:00:00 2001
From: "mergify[bot]" <37929162+mergify[bot]@users.noreply.github.com>
Date: Mon, 2 Dec 2024 22:02:27 +0100
Subject: [PATCH] refactor: remove sysctl dependency from start command
 (backport #4068) (#4072)

## Overview


This change was prompted by an attempt to run the application in an
unprivileged docker container based on a slim image. The absence of the
`sysctl` command causes the application to fail the BBR check, even
though that module is loaded and available.

The goals of this PR are:
- allow the application to run the BBR check in a restricted environment
such as a docker container
- make the application distribution agnostic by removing the `systemd`
dependency
- remove an instance of process forking with `exec`
<hr>This is an automatic backport of pull request #4068 done by
[Mergify](https://mergify.com).

Co-authored-by: Mircea Colonescu <me_mircea@hotmail.com>
---
 cmd/celestia-appd/cmd/start.go | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/cmd/celestia-appd/cmd/start.go b/cmd/celestia-appd/cmd/start.go
index 763f1b6cd5..de97d4dfa0 100644
--- a/cmd/celestia-appd/cmd/start.go
+++ b/cmd/celestia-appd/cmd/start.go
@@ -9,7 +9,6 @@ import (
 	"net"
 	"net/http"
 	"os"
-	"os/exec"
 	"path/filepath"
 	"runtime/pprof"
 	"strings"
@@ -580,6 +579,8 @@ sudo sysctl -p
 
 Then verify BBR is enabled:
 sysctl net.ipv4.tcp_congestion_control
+or
+cat /proc/sys/net/ipv4/tcp_congestion_control
 
 This node will get worse p2p performance using a different congestion control algorithm.
 If you need to bypass this check use the --force-no-bbr flag.
@@ -594,16 +595,15 @@ If you need to bypass this check use the --force-no-bbr flag.
 		return nil
 	}
 
-	cmd := exec.Command("sysctl", "net.ipv4.tcp_congestion_control")
-	output, err := cmd.Output()
+	file, err := os.ReadFile("/proc/sys/net/ipv4/tcp_congestion_control")
 	if err != nil {
 		fmt.Print(warning)
-		return fmt.Errorf("failed to execute 'sysctl net.ipv4.tcp_congestion_control' %w", err)
+		return fmt.Errorf("failed to read file '/proc/sys/net/ipv4/tcp_congestion_control' %w", err)
 	}
 
-	if !strings.Contains(string(output), "bbr") {
+	if !strings.Contains(string(file), "bbr") {
 		fmt.Print(warning)
-		return fmt.Errorf("BBR not enabled because output %v does not contain 'bbr'", string(output))
+		return fmt.Errorf("BBR not enabled because output %v does not contain 'bbr'", string(file))
 	}
 
 	return nil