Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace all default value usage with values from KVStore #1032

Closed
rahulghangas opened this issue Nov 17, 2022 · 1 comment
Closed

Replace all default value usage with values from KVStore #1032

rahulghangas opened this issue Nov 17, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@rahulghangas
Copy link
Contributor

rahulghangas commented Nov 17, 2022 •
edited
Loading

Summary

Currently, the default values for min/max square size are hardcoded in appconsts module and these hardcoded values are used throughout the codebase as is

Proposal

After #893 , these hardcoded values should be replaced with KVStore reads, specifically by caching them in a transient store and using them across all transactions in a block
@rahulghangas rahulghangas added the enhancement New feature or request label Nov 17, 2022
@rahulghangas rahulghangas self-assigned this Nov 17, 2022
@rootulp rootulp mentioned this issue Nov 17, 2022
Merged
1 task
@rahulghangas rahulghangas mentioned this issue Nov 18, 2022
Closed
@evan-forbes
Copy link
Member

closing as this is outdated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rahulghangas @evan-forbes