Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run fuzz tests on every PR #1112

Closed
evan-forbes opened this issue Dec 13, 2022 · 5 comments · Fixed by #2845
Closed

Run fuzz tests on every PR #1112

evan-forbes opened this issue Dec 13, 2022 · 5 comments · Fixed by #2845
Assignees
@rootulp
Labels
good first issue Good for newcomers testing items that are strictly related to adding or extending test coverage

Comments

@evan-forbes
Copy link
Member

we should have longer running fuzzing tests that run after a PR is merged to hopefully catch bugs such as that found in #1108
@evan-forbes evan-forbes added github_actions testing items that are strictly related to adding or extending test coverage labels Dec 13, 2022
@evan-forbes evan-forbes changed the title Run long fuzzing tests per PR after they are merged Run long fuzzing tests after each PR is merged Dec 13, 2022
@evan-forbes evan-forbes added the good first issue Good for newcomers label Dec 13, 2022
@evan-forbes
Copy link
Member Author

consolidating #695 into this issue

@rootulp
Copy link
Collaborator

rootulp commented Nov 15, 2023

Is the proposal to change make test-fuzz to run after every PR instead of just nightly?

@evan-forbes
Copy link
Member Author

yeah, just to hopefully help pinpoint any changes that might have caused the issue. If the fuzzing tests are too long however, we can revert to running them locally

@rootulp
Copy link
Collaborator

rootulp commented Nov 15, 2023

Alternative idea with a similar outcome: run the fuzz tests on every PR as an optional check. Optional checks don't block the PR from merging and we'll get signal on whether the fuzz test passes on a per PR basis.

@evan-forbes
Copy link
Member Author

sgtm

@rootulp rootulp self-assigned this Nov 15, 2023
@rootulp rootulp changed the title Run long fuzzing tests after each PR is merged Run fuzz tests on every PR Nov 15, 2023
@rootulp rootulp mentioned this issue Nov 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rootulp rootulp

Labels
good first issue Good for newcomers testing items that are strictly related to adding or extending test coverage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: run fuzz tests on every PR rootulp/celestia-app
2 participants
@rootulp @evan-forbes