Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for address validation for account emitted in event #1129

Closed
rahulghangas opened this issue Dec 15, 2022 · 1 comment
Closed

Add test for address validation for account emitted in event #1129

rahulghangas opened this issue Dec 15, 2022 · 1 comment
Assignees
@rootulp
Labels
enhancement New feature or request good first issue Good for newcomers ice-box this label is automatically applied to all issues. it is removed after starting work

Comments

@rahulghangas
Copy link
Contributor

rahulghangas commented Dec 15, 2022 •
edited
Loading

Summary

Add test to validate the signer's address' encoding emitted in a pay for blob tx

Linked - #1030
@rahulghangas rahulghangas added the enhancement New feature or request label Dec 15, 2022
@evan-forbes evan-forbes changed the title Add test for address validation for accoutn emitted in event Add test for address validation for account emitted in event Dec 15, 2022
@evan-forbes evan-forbes added the good first issue Good for newcomers label Dec 15, 2022
@evan-forbes evan-forbes added the ice-box this label is automatically applied to all issues. it is removed after starting work label Feb 21, 2024
@rootulp rootulp self-assigned this May 16, 2024
@rootulp
Copy link
Collaborator

rootulp commented May 16, 2024

OMG how did I miss this. This test would've caught this bug pre-mainnet. Fortunately this PR includes a test.

@rootulp rootulp closed this as completed May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rootulp rootulp

Labels
enhancement New feature or request good first issue Good for newcomers ice-box this label is automatically applied to all issues. it is removed after starting work
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rootulp @rahulghangas @evan-forbes