Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look into more intuitive ways to sign malleated transactions #192

Closed
evan-forbes opened this issue Jan 20, 2022 · 2 comments
Closed

Look into more intuitive ways to sign malleated transactions #192

evan-forbes opened this issue Jan 20, 2022 · 2 comments

Comments

@evan-forbes
Copy link
Member

Currently, we use the KeyringSigner to programmatically sign malleated transactions. This is because the standard cosmos-sdk tx.Factory does not support creating multiple malleated transactions and then signing over those as well. We might be able to refactor KeyringSigner so that it's more intuitive.

@tac0turtle
Copy link
Contributor

tac0turtle commented Jan 21, 2022

This is a code smell imo. Duplicating code from the sdk and then seeing comments like

// makeEncodingConfig is copied here so that we don't have to have an
//  import cycle. if possible, use cosmoscmd.MakeEncodingConfig

make me a bit worried that the design is incorrect.

would be nice to remove the testutil/network.go setup as well. Customising the app breaks this because its not automatic in how the app is set up.

@liamsi liamsi moved this to TODO in Celestia Node Jan 30, 2022
@evan-forbes
Copy link
Member Author

evan-forbes commented Nov 15, 2022

closing as this is a duplicate of #294, which we will finally be able to handle now that we can simplify the malleation process using square size independent commitments

Repository owner moved this from TODO to Done in Celestia Node Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

No branches or pull requests

2 participants