Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the simulation package for x/blob module #24

Open
evan-forbes opened this issue Feb 6, 2021 · 7 comments
Open

Implement the simulation package for x/blob module #24

evan-forbes opened this issue Feb 6, 2021 · 7 comments

Comments

@evan-forbes
Copy link
Member

evan-forbes commented Feb 6, 2021

Modules in the sdk all have a package called simulation that interfaces with the simapp framework for fuzzing. Implement the simulation package for lazyledgerapp so that proper simulation fuzzing can be done as described here

@rootulp
Copy link
Collaborator

rootulp commented Jul 27, 2022

I'm a little confused by the reference to lazyledgerapp. I infer that lazyledgerapp was renamed to celestia-app but I don't see a celestia-app module in the x/ directory.

Does this issue apply to the payment module and therefore entail creating a x/payment/simulation package?

@evan-forbes
Copy link
Member Author

Does this issue apply to the payment module and therefore entail creating a x/payment/simulation package?

Yep! this issue is so old we forgot to update it lol

we might not be able to leverage simulations in the payment module as well as other packages, considering that the payment module is all but stateless. Fuzzing is obvi a good goal tho, so we could try to fuzz the new ABCI++ methods in a more rigorous way than what we are currently doing in the app/test package

@rootulp
Copy link
Collaborator

rootulp commented Jul 27, 2022

Every module that implements the Cosmos SDK simulator needs to have a x//simulation package which contains the primary functions required by the fuzz tests: store decoders, randomized genesis state and parameters, weighted operations and proposal contents.

Naive question but can we implement the simulation package for app/test given it doesn't look like a Cosmos SDK module?

@evan-forbes
Copy link
Member Author

evan-forbes commented Jul 27, 2022

Naive question but can we implement the simulation package for app/test given it doesn't look like a Cosmos SDK module?

in the future I think there will definitely be tools that we can use to help fuzz ABCI++ methods, since we're basically the first ones using those methods, those tools don't exist yet.

@rootulp
Copy link
Collaborator

rootulp commented Jul 27, 2022

Got it. Should we close this issue because we can't implement the simulation package for x/payment/ or app/test? Additionally, should we open a new issue to explore fuzz tooling for ABCI++?

@evan-forbes
Copy link
Member Author

good question, I'm not sure. I think we should at least try, there's almost certainly something of value we can get out of it.

We can open an issue to explore testing ABCI++ methods. Some of the informal team is working on some interesting tools iirc

@rootulp rootulp changed the title Implement the simulation package for lazyledgerapp Implement the simulation package for x/payment module Jul 28, 2022
@evan-forbes
Copy link
Member Author

This is blocked until we either #183 or we use a version of the cosmos-sdk with PrepareProposal and ProcessProposal integrated so we can use the simulation manager to test those. In the meantime, we should continue to flesh out our integration tests for those methods.

taking this off of the goals for incentivized testnet until then.

@rahulghangas rahulghangas changed the title Implement the simulation package for x/payment module Implement the simulation package for x/blob module Nov 25, 2022
@rach-id rach-id assigned rahulghangas and unassigned rahulghangas Nov 25, 2022
@rach-id rach-id removed this from Celestia Node Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants