Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write a detailed plan for what is needed to be able to unfork from the sdk and have single binary syncs #2571

Closed
evan-forbes opened this issue Sep 22, 2023 · 1 comment
Labels
ADR item is directly relevant to writing or modifying an ADR

Comments

@evan-forbes
Copy link
Member

In an ideal world, we’d have the ability to sync from a single binary && be able to reuse a lot of the functionality of the sdk without maintaining a fork or massively vendoring everything. Unfortunately, that’s not the case, and we’re stuck in a trilemma.

The trilemma (pick 2):

  • Single binary syncs (and single binary upgrades)
  • Reusing the sdk’s functionality (vs rewriting everything)
  • Unforking (this includes not vendoring)

In order to help the sdk team, we should write out our requirements to be able to break the trilemma above.

@evan-forbes evan-forbes added the ADR item is directly relevant to writing or modifying an ADR label Sep 22, 2023
@evan-forbes
Copy link
Member Author

The current plan is to adopt the cosmos-sdk's yet to be released baseapp that will allow celestia-app to import the old forked cosmos-sdk modules. This means that we don't have to unfork from the current modules

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ADR item is directly relevant to writing or modifying an ADR
Projects
None yet
Development

No branches or pull requests

1 participant