Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit an event when the version changes #2611

Closed
evan-forbes opened this issue Oct 4, 2023 · 1 comment
Closed

Emit an event when the version changes #2611

evan-forbes opened this issue Oct 4, 2023 · 1 comment
Labels
nice to have item is not blocking or required. priority:low optional label to track the relative priority of planned items WS: V2 ✌️ lemongrass hardfork related
Milestone
v2

Comments

@evan-forbes
Copy link
Member

per todo in #2583
@evan-forbes evan-forbes added this to the v2 milestone Oct 4, 2023
@evan-forbes evan-forbes mentioned this issue Oct 4, 2023
Merged
@rootulp rootulp added the WS: V2 ✌️ lemongrass hardfork related label Mar 1, 2024
@rootulp rootulp added the nice to have item is not blocking or required. label Mar 29, 2024
@rootulp rootulp added needs:triage priority:low optional label to track the relative priority of planned items and removed needs:triage labels Apr 9, 2024
@rootulp
Copy link
Collaborator

rootulp commented Apr 12, 2024

Does anyone actually need this? It looks like the Cosmos SDK x/upgrade module doesn't emit events so I don't see a compelling reason to add this for celestia-app.

Ref: https://github.com/cosmos/cosmos-sdk/blob/release/v0.46.x/x/upgrade/spec/03_events.md

@rootulp rootulp closed this as not planned Won't fix, can't repro, duplicate, stale Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
nice to have item is not blocking or required. priority:low optional label to track the relative priority of planned items WS: V2 ✌️ lemongrass hardfork related
Projects
None yet
Milestone
v2
Development

No branches or pull requests
2 participants
@rootulp @evan-forbes