Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing transaction in tx_search #2726

Closed
4 tasks
lzrscg opened this issue Oct 19, 2023 · 3 comments
Closed
4 tasks

Missing transaction in tx_search #2726

lzrscg opened this issue Oct 19, 2023 · 3 comments
Labels
bug Something isn't working WS: Maintenance 🔧 includes bugs, refactors, flakes, and tech debt etc

Comments

@lzrscg
Copy link

lzrscg commented Oct 19, 2023

Summary of Bug

Block 279207 on Mocha 4 has a transaction:
Click here because the response is long

But when using tx_search (http://consensus-full-mocha-4.celestia-mocha.com:26657/tx_search?query=%22tx.height=279207%22) the result is empty:

{
    "jsonrpc": "2.0",
    "id": -1,
    "result": {
        "txs": [],
        "total_count": "0"
    }
}

Expected behavior

Subsequent block 279208 has a transaction.

And so does the tx_search result for 279208.

Version

Presumably v1.1.0, which should be running on http://consensus-full-mocha-4.celestia-mocha.com:26657

We have not replicated this on a local node, but are happy to do so if helpful.

Steps to Reproduce

  1. Use a Mocha 4 node
  2. Make an RPC call using tx_search (docs) for transactions in block 279207. i.e. http://consensus-full-mocha-4.celestia-mocha.com:26657/tx_search?query=%22tx.height=279207%22
  3. Use RPC to independently check block 279207 and see how many transactions are inside result.block.data.txs i.e. http://consensus-full-mocha-4.celestia-mocha.com:26657/block?height=27920
  4. Notice the discrepancy between the number of transactions in the block and the number of results from tx_search

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@lzrscg lzrscg added the bug Something isn't working label Oct 19, 2023
@evan-forbes
Copy link
Member

I think this is the same issue as #2806 (comment)

does that make sense @lzrscg ? also apologies that this issue slipped through the cracks

@mhstom
Copy link

mhstom commented Nov 21, 2023

thanks for the reply @evan-forbes!

based on what we have seen, I don't think it's the same issue. For reasons:

  1. We are using the /tx_search endpoint. Based on our experience, it returns tx regardless of normal tx or payForBlob tx. We are able to get the result for other blocks that have payForBlob transactions
  2. The rpc provided by pops one does return transactions for the same block 279207 http://rpc-mocha.pops.one:26657/tx_search?query=%22tx.height=279207%22 while this http://consensus-full-mocha-4.celestia-mocha.com:26657/tx_search?query=%22tx.height=279207%22 doesn't.

my two cents is that there might be a glitch somewhere in the system.

@evan-forbes evan-forbes added WS: Maintenance 🔧 includes bugs, refactors, flakes, and tech debt etc needs:triage and removed external labels May 17, 2024
@evan-forbes
Copy link
Member

evan-forbes commented Nov 25, 2024

I believe we can close this with celestiaorg/celestia-core#1533

apologies for taking so long to get to @lzrscg this was a non-trivial bug in comet that has been there for years

s/o @ninabarbakadze for fixing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working WS: Maintenance 🔧 includes bugs, refactors, flakes, and tech debt etc
Projects
None yet
Development

No branches or pull requests

3 participants